From 389c8d39f52f9f81fb410fab68cbf9c528e76926 Mon Sep 17 00:00:00 2001
From: Michael <35783820+mib1185@users.noreply.github.com>
Date: Wed, 27 Dec 2023 18:28:24 +0100
Subject: [PATCH] Add significant Change support for cover (#106016)

---
 .../components/cover/significant_change.py    | 55 ++++++++++++++++
 .../cover/test_significant_change.py          | 65 +++++++++++++++++++
 2 files changed, 120 insertions(+)
 create mode 100644 homeassistant/components/cover/significant_change.py
 create mode 100644 tests/components/cover/test_significant_change.py

diff --git a/homeassistant/components/cover/significant_change.py b/homeassistant/components/cover/significant_change.py
new file mode 100644
index 00000000000..8762af496c8
--- /dev/null
+++ b/homeassistant/components/cover/significant_change.py
@@ -0,0 +1,55 @@
+"""Helper to test significant Cover state changes."""
+from __future__ import annotations
+
+from typing import Any
+
+from homeassistant.core import HomeAssistant, callback
+from homeassistant.helpers.significant_change import (
+    check_absolute_change,
+    check_valid_float,
+)
+
+from . import ATTR_CURRENT_POSITION, ATTR_CURRENT_TILT_POSITION
+
+SIGNIFICANT_ATTRIBUTES: set[str] = {
+    ATTR_CURRENT_POSITION,
+    ATTR_CURRENT_TILT_POSITION,
+}
+
+
+@callback
+def async_check_significant_change(
+    hass: HomeAssistant,
+    old_state: str,
+    old_attrs: dict,
+    new_state: str,
+    new_attrs: dict,
+    **kwargs: Any,
+) -> bool | None:
+    """Test if state significantly changed."""
+    if old_state != new_state:
+        return True
+
+    old_attrs_s = set(old_attrs.items())
+    new_attrs_s = set(new_attrs.items())
+    changed_attrs: set[str] = {item[0] for item in old_attrs_s ^ new_attrs_s}
+
+    for attr_name in changed_attrs:
+        if attr_name not in SIGNIFICANT_ATTRIBUTES:
+            continue
+
+        old_attr_value = old_attrs.get(attr_name)
+        new_attr_value = new_attrs.get(attr_name)
+        if new_attr_value is None or not check_valid_float(new_attr_value):
+            # New attribute value is invalid, ignore it
+            continue
+
+        if old_attr_value is None or not check_valid_float(old_attr_value):
+            # Old attribute value was invalid, we should report again
+            return True
+
+        if check_absolute_change(old_attr_value, new_attr_value, 1.0):
+            return True
+
+    # no significant attribute change detected
+    return False
diff --git a/tests/components/cover/test_significant_change.py b/tests/components/cover/test_significant_change.py
new file mode 100644
index 00000000000..9ddb2cb9498
--- /dev/null
+++ b/tests/components/cover/test_significant_change.py
@@ -0,0 +1,65 @@
+"""Test the Cover significant change platform."""
+import pytest
+
+from homeassistant.components.cover import (
+    ATTR_CURRENT_POSITION,
+    ATTR_CURRENT_TILT_POSITION,
+)
+from homeassistant.components.cover.significant_change import (
+    async_check_significant_change,
+)
+
+
+async def test_significant_state_change() -> None:
+    """Detect Cover significant state changes."""
+    attrs = {}
+    assert not async_check_significant_change(None, "on", attrs, "on", attrs)
+    assert async_check_significant_change(None, "on", attrs, "off", attrs)
+
+
+@pytest.mark.parametrize(
+    ("old_attrs", "new_attrs", "expected_result"),
+    [
+        # float attributes
+        ({ATTR_CURRENT_POSITION: 60.0}, {ATTR_CURRENT_POSITION: 61.0}, True),
+        ({ATTR_CURRENT_POSITION: 60.0}, {ATTR_CURRENT_POSITION: 60.9}, False),
+        ({ATTR_CURRENT_POSITION: "invalid"}, {ATTR_CURRENT_POSITION: 60.0}, True),
+        ({ATTR_CURRENT_POSITION: 60.0}, {ATTR_CURRENT_POSITION: "invalid"}, False),
+        ({ATTR_CURRENT_TILT_POSITION: 60.0}, {ATTR_CURRENT_TILT_POSITION: 61.0}, True),
+        ({ATTR_CURRENT_TILT_POSITION: 60.0}, {ATTR_CURRENT_TILT_POSITION: 60.9}, False),
+        # multiple attributes
+        (
+            {
+                ATTR_CURRENT_POSITION: 60,
+                ATTR_CURRENT_TILT_POSITION: 60,
+            },
+            {
+                ATTR_CURRENT_POSITION: 60,
+                ATTR_CURRENT_TILT_POSITION: 61,
+            },
+            True,
+        ),
+        (
+            {
+                ATTR_CURRENT_POSITION: 60,
+                ATTR_CURRENT_TILT_POSITION: 59.1,
+            },
+            {
+                ATTR_CURRENT_POSITION: 60,
+                ATTR_CURRENT_TILT_POSITION: 60.9,
+            },
+            True,
+        ),
+        # insignificant attributes
+        ({"unknown_attr": "old_value"}, {"unknown_attr": "old_value"}, False),
+        ({"unknown_attr": "old_value"}, {"unknown_attr": "new_value"}, False),
+    ],
+)
+async def test_significant_atributes_change(
+    old_attrs: dict, new_attrs: dict, expected_result: bool
+) -> None:
+    """Detect Cover significant attribute changes."""
+    assert (
+        async_check_significant_change(None, "state", old_attrs, "state", new_attrs)
+        == expected_result
+    )