From 38a8e86ddeb65ee8c731b90a7063a3b3702dc1ef Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Thu, 17 Nov 2022 10:45:32 +0100 Subject: [PATCH] Cleanup supported_features in group (#82242) * Cleanup supported_features in group * Remove defaults (already set to 0 in fan and media_player) --- homeassistant/components/group/fan.py | 8 +------- homeassistant/components/group/media_player.py | 8 +------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/homeassistant/components/group/fan.py b/homeassistant/components/group/fan.py index 7d09c9573b5..09b59a2d123 100644 --- a/homeassistant/components/group/fan.py +++ b/homeassistant/components/group/fan.py @@ -110,18 +110,12 @@ class FanGroup(GroupEntity, FanEntity): self._percentage = None self._oscillating = None self._direction = None - self._supported_features = 0 self._speed_count = 100 self._is_on: bool | None = False self._attr_name = name self._attr_extra_state_attributes = {ATTR_ENTITY_ID: entities} self._attr_unique_id = unique_id - @property - def supported_features(self) -> int: - """Flag supported features.""" - return self._supported_features - @property def speed_count(self) -> int: """Return the number of speeds the fan supports.""" @@ -319,7 +313,7 @@ class FanGroup(GroupEntity, FanEntity): "_direction", FanEntityFeature.DIRECTION, ATTR_DIRECTION ) - self._supported_features = reduce( + self._attr_supported_features = reduce( ior, [feature for feature in SUPPORTED_FLAGS if self._fans[feature]], 0 ) self._attr_assumed_state |= any( diff --git a/homeassistant/components/group/media_player.py b/homeassistant/components/group/media_player.py index ddb44072080..2e46599aba1 100644 --- a/homeassistant/components/group/media_player.py +++ b/homeassistant/components/group/media_player.py @@ -109,7 +109,6 @@ class MediaPlayerGroup(MediaPlayerEntity): """Initialize a Media Group entity.""" self._name = name self._state: str | None = None - self._supported_features: int = 0 self._attr_unique_id = unique_id self._entities = entities @@ -212,11 +211,6 @@ class MediaPlayerGroup(MediaPlayerEntity): """Return the state of the media group.""" return self._state - @property - def supported_features(self) -> int: - """Flag supported features.""" - return self._supported_features - @property def extra_state_attributes(self) -> dict: """Return the state attributes for the media group.""" @@ -442,5 +436,5 @@ class MediaPlayerGroup(MediaPlayerEntity): | MediaPlayerEntityFeature.VOLUME_STEP ) - self._supported_features = supported_features + self._attr_supported_features = supported_features self.async_write_ha_state()