From 39208a3749914f9f5cc8a1febcb4c7c149e9079d Mon Sep 17 00:00:00 2001 From: Erik Montnemery Date: Mon, 10 Jul 2023 15:03:40 +0200 Subject: [PATCH] Remove unsupported vacuum service handlers (#95787) * Prevent implementing unsupported vacuum service handlers * Remove unsupported service handlers * Update test --- homeassistant/components/vacuum/__init__.py | 15 --------------- tests/components/demo/test_vacuum.py | 4 ++-- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/homeassistant/components/vacuum/__init__.py b/homeassistant/components/vacuum/__init__.py index 0dc4d19ba36..2399e5d9b3b 100644 --- a/homeassistant/components/vacuum/__init__.py +++ b/homeassistant/components/vacuum/__init__.py @@ -429,12 +429,6 @@ class VacuumEntity(_BaseVacuum, ToggleEntity): """ await self.hass.async_add_executor_job(partial(self.start_pause, **kwargs)) - async def async_pause(self) -> None: - """Not supported.""" - - async def async_start(self) -> None: - """Not supported.""" - @dataclass class StateVacuumEntityDescription(EntityDescription): @@ -482,12 +476,3 @@ class StateVacuumEntity(_BaseVacuum): This method must be run in the event loop. """ await self.hass.async_add_executor_job(self.pause) - - async def async_turn_on(self, **kwargs: Any) -> None: - """Not supported.""" - - async def async_turn_off(self, **kwargs: Any) -> None: - """Not supported.""" - - async def async_toggle(self, **kwargs: Any) -> None: - """Not supported.""" diff --git a/tests/components/demo/test_vacuum.py b/tests/components/demo/test_vacuum.py index 4f977436055..711d0217f2d 100644 --- a/tests/components/demo/test_vacuum.py +++ b/tests/components/demo/test_vacuum.py @@ -241,8 +241,8 @@ async def test_unsupported_methods(hass: HomeAssistant) -> None: await hass.async_block_till_done() assert vacuum.is_on(hass, ENTITY_VACUUM_COMPLETE) - await common.async_pause(hass, ENTITY_VACUUM_COMPLETE) - assert vacuum.is_on(hass, ENTITY_VACUUM_COMPLETE) + with pytest.raises(AttributeError): + await common.async_pause(hass, ENTITY_VACUUM_COMPLETE) hass.states.async_set(ENTITY_VACUUM_COMPLETE, STATE_OFF) await hass.async_block_till_done()