From 3958d89ae6bbd07c160a44d7d71e3a235c45b772 Mon Sep 17 00:00:00 2001
From: Erwin Douna <e.douna@gmail.com>
Date: Mon, 8 Jan 2024 09:57:01 +0100
Subject: [PATCH] Improve typing for Tado (#106992)

---
 homeassistant/components/tado/entity.py |  7 ++++---
 homeassistant/components/tado/sensor.py | 25 ++++++++++++++-----------
 2 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/homeassistant/components/tado/entity.py b/homeassistant/components/tado/entity.py
index 532d784b190..417cfe939d4 100644
--- a/homeassistant/components/tado/entity.py
+++ b/homeassistant/components/tado/entity.py
@@ -2,6 +2,7 @@
 from homeassistant.helpers.device_registry import DeviceInfo
 from homeassistant.helpers.entity import Entity
 
+from . import TadoConnector
 from .const import DEFAULT_NAME, DOMAIN, TADO_HOME, TADO_ZONE
 
 
@@ -11,7 +12,7 @@ class TadoDeviceEntity(Entity):
     _attr_should_poll = False
     _attr_has_entity_name = True
 
-    def __init__(self, device_info):
+    def __init__(self, device_info: dict[str, str]) -> None:
         """Initialize a Tado device."""
         super().__init__()
         self._device_info = device_info
@@ -34,7 +35,7 @@ class TadoHomeEntity(Entity):
     _attr_should_poll = False
     _attr_has_entity_name = True
 
-    def __init__(self, tado):
+    def __init__(self, tado: TadoConnector) -> None:
         """Initialize a Tado home."""
         super().__init__()
         self.home_name = tado.home_name
@@ -54,7 +55,7 @@ class TadoZoneEntity(Entity):
     _attr_has_entity_name = True
     _attr_should_poll = False
 
-    def __init__(self, zone_name, home_id, zone_id):
+    def __init__(self, zone_name: str, home_id: int, zone_id: int) -> None:
         """Initialize a Tado zone."""
         super().__init__()
         self.zone_name = zone_name
diff --git a/homeassistant/components/tado/sensor.py b/homeassistant/components/tado/sensor.py
index a9647c7e6e5..4ff12a6e51d 100644
--- a/homeassistant/components/tado/sensor.py
+++ b/homeassistant/components/tado/sensor.py
@@ -19,6 +19,7 @@ from homeassistant.helpers.dispatcher import async_dispatcher_connect
 from homeassistant.helpers.entity_platform import AddEntitiesCallback
 from homeassistant.helpers.typing import StateType
 
+from . import TadoConnector
 from .const import (
     CONDITIONS_MAP,
     DATA,
@@ -60,14 +61,14 @@ def format_condition(condition: str) -> str:
     return condition
 
 
-def get_tado_mode(data) -> str | None:
+def get_tado_mode(data: dict[str, str]) -> str | None:
     """Return Tado Mode based on Presence attribute."""
     if "presence" in data:
         return data["presence"]
     return None
 
 
-def get_automatic_geofencing(data) -> bool:
+def get_automatic_geofencing(data: dict[str, str]) -> bool:
     """Return whether Automatic Geofencing is enabled based on Presence Locked attribute."""
     if "presenceLocked" in data:
         if data["presenceLocked"]:
@@ -76,7 +77,7 @@ def get_automatic_geofencing(data) -> bool:
     return False
 
 
-def get_geofencing_mode(data) -> str:
+def get_geofencing_mode(data: dict[str, str]) -> str:
     """Return Geofencing Mode based on Presence and Presence Locked attributes."""
     tado_mode = ""
     tado_mode = data.get("presence", "unknown")
@@ -240,7 +241,9 @@ class TadoHomeSensor(TadoHomeEntity, SensorEntity):
 
     entity_description: TadoSensorEntityDescription
 
-    def __init__(self, tado, entity_description: TadoSensorEntityDescription) -> None:
+    def __init__(
+        self, tado: TadoConnector, entity_description: TadoSensorEntityDescription
+    ) -> None:
         """Initialize of the Tado Sensor."""
         self.entity_description = entity_description
         super().__init__(tado)
@@ -261,13 +264,13 @@ class TadoHomeSensor(TadoHomeEntity, SensorEntity):
         self._async_update_home_data()
 
     @callback
-    def _async_update_callback(self):
+    def _async_update_callback(self) -> None:
         """Update and write state."""
         self._async_update_home_data()
         self.async_write_ha_state()
 
     @callback
-    def _async_update_home_data(self):
+    def _async_update_home_data(self) -> None:
         """Handle update callbacks."""
         try:
             tado_weather_data = self._tado.data["weather"]
@@ -294,9 +297,9 @@ class TadoZoneSensor(TadoZoneEntity, SensorEntity):
 
     def __init__(
         self,
-        tado,
-        zone_name,
-        zone_id,
+        tado: TadoConnector,
+        zone_name: str,
+        zone_id: int,
         entity_description: TadoSensorEntityDescription,
     ) -> None:
         """Initialize of the Tado Sensor."""
@@ -321,13 +324,13 @@ class TadoZoneSensor(TadoZoneEntity, SensorEntity):
         self._async_update_zone_data()
 
     @callback
-    def _async_update_callback(self):
+    def _async_update_callback(self) -> None:
         """Update and write state."""
         self._async_update_zone_data()
         self.async_write_ha_state()
 
     @callback
-    def _async_update_zone_data(self):
+    def _async_update_zone_data(self) -> None:
         """Handle update callbacks."""
         try:
             tado_zone_data = self._tado.data["zone"][self.zone_id]