jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address late review of Fritz switch (#54842)

Browse Source
This commit is contained in:
Aaron David Schneider 2021-08-24 18:10:32 +02:00 committed by GitHub
parent 38f0020619
commit 39d5ae77a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
homeassistant/components/fritz/switch.py
View File

@ -408,11 +408,10 @@ class FritzBoxBaseSwitch(FritzBoxBaseEntity):
"""Turn off switch.""" """Turn off switch."""
await self._async_handle_turn_on_off(turn_on=False) await self._async_handle_turn_on_off(turn_on=False)
async def _async_handle_turn_on_off(self, turn_on: bool) -> bool: async def _async_handle_turn_on_off(self, turn_on: bool) -> None:
"""Handle switch state change request.""" """Handle switch state change request."""
await self._switch(turn_on) await self._switch(turn_on)
self._attr_is_on = turn_on self._attr_is_on = turn_on
return True
class FritzBoxPortSwitch(FritzBoxBaseSwitch, SwitchEntity): class FritzBoxPortSwitch(FritzBoxBaseSwitch, SwitchEntity):
@ -468,9 +467,9 @@ class FritzBoxPortSwitch(FritzBoxBaseSwitch, SwitchEntity):
self._is_available = True self._is_available = True
attributes_dict = { attributes_dict = {
"NewInternalClient": "internalIP", "NewInternalClient": "internal_ip",
"NewInternalPort": "internalPort", "NewInternalPort": "internal_port",
"NewExternalPort": "externalPort", "NewExternalPort": "external_port",
"NewProtocol": "protocol", "NewProtocol": "protocol",
"NewPortMappingDescription": "description", "NewPortMappingDescription": "description",
} }
@ -547,15 +546,15 @@ class FritzBoxDeflectionSwitch(FritzBoxBaseSwitch, SwitchEntity):
self._attr_is_on = self.dict_of_deflection["Enable"] == "1" self._attr_is_on = self.dict_of_deflection["Enable"] == "1"
self._is_available = True self._is_available = True
self._attributes["Type"] = self.dict_of_deflection["Type"] self._attributes["type"] = self.dict_of_deflection["Type"]
self._attributes["Number"] = self.dict_of_deflection["Number"] self._attributes["number"] = self.dict_of_deflection["Number"]
self._attributes["DeflectionToNumber"] = self.dict_of_deflection[ self._attributes["deflection_to_number"] = self.dict_of_deflection[
"DeflectionToNumber" "DeflectionToNumber"
] ]
# Return mode sample: "eImmediately" # Return mode sample: "eImmediately"
self._attributes["Mode"] = self.dict_of_deflection["Mode"][1:] self._attributes["mode"] = self.dict_of_deflection["Mode"][1:]
self._attributes["Outgoing"] = self.dict_of_deflection["Outgoing"] self._attributes["outgoing"] = self.dict_of_deflection["Outgoing"]
self._attributes["PhonebookID"] = self.dict_of_deflection["PhonebookID"] self._attributes["phonebook_id"] = self.dict_of_deflection["PhonebookID"]
async def _async_switch_on_off_executor(self, turn_on: bool) -> None: async def _async_switch_on_off_executor(self, turn_on: bool) -> None:
"""Handle deflection switch.""" """Handle deflection switch."""
@ -674,7 +673,7 @@ class FritzBoxWifiSwitch(FritzBoxBaseSwitch, SwitchEntity):
std = wifi_info["NewStandard"] std = wifi_info["NewStandard"]
self._attributes["standard"] = std if std else None self._attributes["standard"] = std if std else None
self._attributes["BSSID"] = wifi_info["NewBSSID"] self._attributes["bssid"] = wifi_info["NewBSSID"]
self._attributes["mac_address_control"] = wifi_info[ self._attributes["mac_address_control"] = wifi_info[
"NewMACAddressControlEnabled" "NewMACAddressControlEnabled"
] ]