jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-24 05:37:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Filter continuous values from logbook (#2761)

Browse Source 
* Filter continuous values from logbook

* Test filter continuous values from logbook
This commit is contained in:
Adam Mills 2016-08-09 11:01:02 -04:00 committed by Paulus Schoutsen
parent 0b7b0e54ba
commit 3ac9aaf025
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/logbook.py
View File

@ -194,6 +194,11 @@ def humanify(events):
event != last_sensor_event[to_state.entity_id]: event != last_sensor_event[to_state.entity_id]:
continue continue
# Don't show continuous sensor value changes in the logbook
if domain == 'sensor' and \
to_state.attributes.get('unit_of_measurement'):
continue
yield Entry( yield Entry(
event.time_fired, event.time_fired,
name=to_state.name, name=to_state.name,

17
tests/components/test_logbook.py
View File

@ -85,6 +85,18 @@ class TestComponentLogbook(unittest.TestCase):
self.assert_entry( self.assert_entry(
entries[1], pointC, 'bla', domain='sensor', entity_id=entity_id) entries[1], pointC, 'bla', domain='sensor', entity_id=entity_id)
def test_filter_continuous_sensor_values(self):
"""Test remove continuous sensor events from logbook"""
entity_id = 'sensor.bla'
pointA = dt_util.utcnow()
attributes = {'unit_of_measurement': 'foo'}
eventA = self.create_state_changed_event(
pointA, entity_id, 10, attributes)
entries = list(logbook.humanify((eventA,)))
self.assertEqual(0, len(entries))
def test_entry_to_dict(self): def test_entry_to_dict(self):
"""Test conversion of entry to dict.""" """Test conversion of entry to dict."""
entry = logbook.Entry( entry = logbook.Entry(
@ -148,11 +160,12 @@ class TestComponentLogbook(unittest.TestCase):
if entity_id: if entity_id:
self.assertEqual(entity_id, entry.entity_id) self.assertEqual(entity_id, entry.entity_id)
def create_state_changed_event(self, event_time_fired, entity_id, state): def create_state_changed_event(self, event_time_fired, entity_id, state,
attributes=None):
"""Create state changed event.""" """Create state changed event."""
# Logbook only cares about state change events that # Logbook only cares about state change events that
# contain an old state but will not actually act on it. # contain an old state but will not actually act on it.
state = ha.State(entity_id, state).as_dict() state = ha.State(entity_id, state, attributes).as_dict()
return ha.Event(EVENT_STATE_CHANGED, { return ha.Event(EVENT_STATE_CHANGED, {
'entity_id': entity_id, 'entity_id': entity_id,