From 3b08d5f0c36ff45b3732a14f027d9da66ed09e25 Mon Sep 17 00:00:00 2001 From: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Date: Sun, 11 Jun 2023 02:28:32 +0200 Subject: [PATCH] Improve renson typing (#94390) --- homeassistant/components/renson/__init__.py | 3 ++- homeassistant/components/renson/entity.py | 2 +- homeassistant/components/renson/sensor.py | 13 +++++-------- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/homeassistant/components/renson/__init__.py b/homeassistant/components/renson/__init__.py index 2e2f4e8f253..211f7c88e40 100644 --- a/homeassistant/components/renson/__init__.py +++ b/homeassistant/components/renson/__init__.py @@ -4,6 +4,7 @@ from __future__ import annotations from dataclasses import dataclass from datetime import timedelta import logging +from typing import Any import async_timeout from renson_endura_delta.renson import RensonVentilation @@ -81,7 +82,7 @@ class RensonCoordinator(DataUpdateCoordinator): ) self.api = api - async def _async_update_data(self): + async def _async_update_data(self) -> dict[str, Any]: """Fetch data from API endpoint.""" async with async_timeout.timeout(30): return await self.hass.async_add_executor_job(self.api.get_all_data) diff --git a/homeassistant/components/renson/entity.py b/homeassistant/components/renson/entity.py index 9ba30b43aa7..526077d2d7f 100644 --- a/homeassistant/components/renson/entity.py +++ b/homeassistant/components/renson/entity.py @@ -16,7 +16,7 @@ from . import RensonCoordinator from .const import DOMAIN -class RensonEntity(CoordinatorEntity): +class RensonEntity(CoordinatorEntity[RensonCoordinator]): """Renson entity.""" def __init__( diff --git a/homeassistant/components/renson/sensor.py b/homeassistant/components/renson/sensor.py index dc9f69c2914..9817951b094 100644 --- a/homeassistant/components/renson/sensor.py +++ b/homeassistant/components/renson/sensor.py @@ -46,7 +46,7 @@ from homeassistant.const import ( from homeassistant.core import HomeAssistant, callback from homeassistant.helpers.entity_platform import AddEntitiesCallback -from . import RensonCoordinator +from . import RensonCoordinator, RensonData from .const import DOMAIN from .entity import RensonEntity @@ -305,13 +305,10 @@ async def async_setup_entry( ) -> None: """Set up the Renson sensor platform.""" - api: RensonVentilation = hass.data[DOMAIN][config_entry.entry_id].api - coordinator: RensonCoordinator = hass.data[DOMAIN][ - config_entry.entry_id - ].coordinator + data: RensonData = hass.data[DOMAIN][config_entry.entry_id] - entities: list = [] - for description in SENSORS: - entities.append(RensonSensor(description, api, coordinator)) + entities = [ + RensonSensor(description, data.api, data.coordinator) for description in SENSORS + ] async_add_entities(entities)