jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-04-26 02:07:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add current_humidity to humidifiers in google_assistant (#94935)

Browse Source
This commit is contained in:
Jan Bouwhuis 2023-06-20 22:49:10 +02:00 committed by GitHub
parent d6b89b6f7b
commit 3b8feab699
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/components/google_assistant/trait.py
View File

@ -1216,9 +1216,12 @@ class HumiditySettingTrait(_Trait):
response["humidityAmbientPercent"] = round(float(current_humidity)) response["humidityAmbientPercent"] = round(float(current_humidity))
elif domain == humidifier.DOMAIN: elif domain == humidifier.DOMAIN:
target_humidity = attrs.get(humidifier.ATTR_HUMIDITY) target_humidity: int | None = attrs.get(humidifier.ATTR_HUMIDITY)
if target_humidity is not None: if target_humidity is not None:
response["humiditySetpointPercent"] = round(float(target_humidity)) response["humiditySetpointPercent"] = target_humidity
current_humidity: int | None = attrs.get(humidifier.ATTR_CURRENT_HUMIDITY)
if current_humidity is not None:
response["humidityAmbientPercent"] = current_humidity
return response return response

2
tests/components/google_assistant/test_google_assistant.py
View File

@ -351,11 +351,13 @@ async def test_query_humidifier_request(
"on": True, "on": True,
"online": True, "online": True,
"humiditySetpointPercent": 68, "humiditySetpointPercent": 68,
"humidityAmbientPercent": 45,
} }
assert devices["humidifier.dehumidifier"] == { assert devices["humidifier.dehumidifier"] == {
"on": True, "on": True,
"online": True, "online": True,
"humiditySetpointPercent": 54, "humiditySetpointPercent": 54,
"humidityAmbientPercent": 59,
} }
assert devices["humidifier.hygrostat"] == { assert devices["humidifier.hygrostat"] == {
"on": True, "on": True,

2
tests/components/google_assistant/test_trait.py
View File

@ -1203,6 +1203,7 @@ async def test_humidity_setting_humidifier_setpoint(hass: HomeAssistant) -> None
humidifier.ATTR_MIN_HUMIDITY: 20, humidifier.ATTR_MIN_HUMIDITY: 20,
humidifier.ATTR_MAX_HUMIDITY: 90, humidifier.ATTR_MAX_HUMIDITY: 90,
humidifier.ATTR_HUMIDITY: 38, humidifier.ATTR_HUMIDITY: 38,
humidifier.ATTR_CURRENT_HUMIDITY: 30,
}, },
), ),
BASIC_CONFIG, BASIC_CONFIG,
@ -1212,6 +1213,7 @@ async def test_humidity_setting_humidifier_setpoint(hass: HomeAssistant) -> None
} }
assert trt.query_attributes() == { assert trt.query_attributes() == {
"humiditySetpointPercent": 38, "humiditySetpointPercent": 38,
"humidityAmbientPercent": 30,
} }
assert trt.can_execute(trait.COMMAND_SET_HUMIDITY, {}) assert trt.can_execute(trait.COMMAND_SET_HUMIDITY, {})