jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 10:47:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Airzone temperature range on new climate card (#105830)

Browse Source 
* airzone: climate: fix double setpoint

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

* tests: airzone: fix double setpoint temperature

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

* tests: airzone: fix swapped double setpoint

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

---------

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This commit is contained in:
Álvaro Fernández Rojas 2023-12-16 18:42:58 +01:00 committed by GitHub
parent 755dcd8bc6
commit 3be12c0611
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/components/airzone/climate.py
View File

@ -248,7 +248,6 @@ class AirzoneClimate(AirzoneZoneEntity, ClimateEntity):
self._attr_hvac_mode = HVACMode.OFF self._attr_hvac_mode = HVACMode.OFF
self._attr_max_temp = self.get_airzone_value(AZD_TEMP_MAX) self._attr_max_temp = self.get_airzone_value(AZD_TEMP_MAX)
self._attr_min_temp = self.get_airzone_value(AZD_TEMP_MIN) self._attr_min_temp = self.get_airzone_value(AZD_TEMP_MIN)
self._attr_target_temperature = self.get_airzone_value(AZD_TEMP_SET)
if self.supported_features & ClimateEntityFeature.FAN_MODE: if self.supported_features & ClimateEntityFeature.FAN_MODE:
self._attr_fan_mode = self._speeds.get(self.get_airzone_value(AZD_SPEED)) self._attr_fan_mode = self._speeds.get(self.get_airzone_value(AZD_SPEED))
if self.supported_features & ClimateEntityFeature.TARGET_TEMPERATURE_RANGE: if self.supported_features & ClimateEntityFeature.TARGET_TEMPERATURE_RANGE:
@ -258,3 +257,5 @@ class AirzoneClimate(AirzoneZoneEntity, ClimateEntity):
self._attr_target_temperature_low = self.get_airzone_value( self._attr_target_temperature_low = self.get_airzone_value(
AZD_HEAT_TEMP_SET AZD_HEAT_TEMP_SET
) )
else:
self._attr_target_temperature = self.get_airzone_value(AZD_TEMP_SET)

8
tests/components/airzone/snapshots/test_diagnostics.ambr
View File

@ -188,7 +188,7 @@
'coldStages': 0, 'coldStages': 0,
'coolmaxtemp': 90, 'coolmaxtemp': 90,
'coolmintemp': 64, 'coolmintemp': 64,
'coolsetpoint': 73, 'coolsetpoint': 77,
'errors': list([ 'errors': list([
]), ]),
'floor_demand': 0, 'floor_demand': 0,
@ -196,7 +196,7 @@
'heatStages': 0, 'heatStages': 0,
'heatmaxtemp': 86, 'heatmaxtemp': 86,
'heatmintemp': 50, 'heatmintemp': 50,
'heatsetpoint': 77, 'heatsetpoint': 73,
'humidity': 0, 'humidity': 0,
'maxTemp': 90, 'maxTemp': 90,
'minTemp': 64, 'minTemp': 64,
@ -645,7 +645,7 @@
'cold-stage': 0, 'cold-stage': 0,
'cool-temp-max': 90.0, 'cool-temp-max': 90.0,
'cool-temp-min': 64.0, 'cool-temp-min': 64.0,
'cool-temp-set': 73.0, 'cool-temp-set': 77.0,
'demand': True, 'demand': True,
'double-set-point': True, 'double-set-point': True,
'floor-demand': False, 'floor-demand': False,
@ -653,7 +653,7 @@
'heat-stage': 0, 'heat-stage': 0,
'heat-temp-max': 86.0, 'heat-temp-max': 86.0,
'heat-temp-min': 50.0, 'heat-temp-min': 50.0,
'heat-temp-set': 77.0, 'heat-temp-set': 73.0,
'id': 1, 'id': 1,
'master': True, 'master': True,
'mode': 7, 'mode': 7,

11
tests/components/airzone/test_climate.py
View File

@ -221,7 +221,8 @@ async def test_airzone_create_climates(hass: HomeAssistant) -> None:
assert state.attributes.get(ATTR_MAX_TEMP) == 32.2 assert state.attributes.get(ATTR_MAX_TEMP) == 32.2
assert state.attributes.get(ATTR_MIN_TEMP) == 17.8 assert state.attributes.get(ATTR_MIN_TEMP) == 17.8
assert state.attributes.get(ATTR_TARGET_TEMP_STEP) == API_TEMPERATURE_STEP assert state.attributes.get(ATTR_TARGET_TEMP_STEP) == API_TEMPERATURE_STEP
assert state.attributes.get(ATTR_TEMPERATURE) == 22.8 assert state.attributes.get(ATTR_TARGET_TEMP_HIGH) == 25.0
assert state.attributes.get(ATTR_TARGET_TEMP_LOW) == 22.8
HVAC_MOCK_CHANGED = copy.deepcopy(HVAC_MOCK) HVAC_MOCK_CHANGED = copy.deepcopy(HVAC_MOCK)
HVAC_MOCK_CHANGED[API_SYSTEMS][0][API_DATA][0][API_MAX_TEMP] = 25 HVAC_MOCK_CHANGED[API_SYSTEMS][0][API_DATA][0][API_MAX_TEMP] = 25
@ -594,8 +595,8 @@ async def test_airzone_climate_set_temp_range(hass: HomeAssistant) -> None:
{ {
API_SYSTEM_ID: 3, API_SYSTEM_ID: 3,
API_ZONE_ID: 1, API_ZONE_ID: 1,
API_COOL_SET_POINT: 68.0, API_COOL_SET_POINT: 77.0,
API_HEAT_SET_POINT: 77.0, API_HEAT_SET_POINT: 68.0,
} }
] ]
} }
@ -618,5 +619,5 @@ async def test_airzone_climate_set_temp_range(hass: HomeAssistant) -> None:
) )
state = hass.states.get("climate.dkn_plus") state = hass.states.get("climate.dkn_plus")
assert state.attributes.get(ATTR_TARGET_TEMP_HIGH) == 20.0 assert state.attributes.get(ATTR_TARGET_TEMP_HIGH) == 25.0
assert state.attributes.get(ATTR_TARGET_TEMP_LOW) == 25.0 assert state.attributes.get(ATTR_TARGET_TEMP_LOW) == 20.0

4
tests/components/airzone/util.py
View File

@ -245,10 +245,10 @@ HVAC_MOCK = {
API_ZONE_ID: 1, API_ZONE_ID: 1,
API_NAME: "DKN Plus", API_NAME: "DKN Plus",
API_ON: 1, API_ON: 1,
API_COOL_SET_POINT: 73, API_COOL_SET_POINT: 77,
API_COOL_MAX_TEMP: 90, API_COOL_MAX_TEMP: 90,
API_COOL_MIN_TEMP: 64, API_COOL_MIN_TEMP: 64,
API_HEAT_SET_POINT: 77, API_HEAT_SET_POINT: 73,
API_HEAT_MAX_TEMP: 86, API_HEAT_MAX_TEMP: 86,
API_HEAT_MIN_TEMP: 50, API_HEAT_MIN_TEMP: 50,
API_MAX_TEMP: 90, API_MAX_TEMP: 90,