jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 17:57:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address late feedback in SFR Box enum sensors (#84977)

Browse Source 
* Address late feedback to SFR Box

* Hassfest

* missed a capital G

* Apply suggestion
This commit is contained in:
epenet 2023-01-06 11:13:33 +01:00 committed by GitHub
parent 39b110b9b0
commit 3ecbb235cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 76 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
homeassistant/components/sfr_box/sensor.py
View File

@ -120,14 +120,15 @@ SENSOR_TYPES: tuple[SFRBoxSensorEntityDescription, ...] = (
entity_category=EntityCategory.DIAGNOSTIC, entity_category=EntityCategory.DIAGNOSTIC,
entity_registry_enabled_default=False, entity_registry_enabled_default=False,
options=[ options=[
"No Defect", "no_defect",
"Of Frame", "of_frame",
"Loss Of Signal", "loss_of_signal",
"Loss Of Power", "loss_of_power",
"Loss Of Signal Quality", "loss_of_signal_quality",
"Unknown", "unknown",
], ],
value_fn=lambda x: x.line_status, translation_key="line_status",
value_fn=lambda x: x.line_status.lower().replace(" ", "_"),
), ),
SFRBoxSensorEntityDescription( SFRBoxSensorEntityDescription(
key="training", key="training",
@ -136,18 +137,19 @@ SENSOR_TYPES: tuple[SFRBoxSensorEntityDescription, ...] = (
entity_category=EntityCategory.DIAGNOSTIC, entity_category=EntityCategory.DIAGNOSTIC,
entity_registry_enabled_default=False, entity_registry_enabled_default=False,
options=[ options=[
"Idle", "idle",
"G.994 Training", "g_994_training",
"G.992 Started", "g_992_started",
"G.922 Channel Analysis", "g_922_channel_analysis",
"G.992 Message Exchange", "g_992_message_exchange",
"G.993 Started", "g_993_started",
"G.993 Channel Analysis", "g_993_channel_analysis",
"G.993 Message Exchange", "g_993_message_exchange",
"Showtime", "showtime",
"Unknown", "unknown",
], ],
value_fn=lambda x: x.training, translation_key="training",
value_fn=lambda x: x.training.lower().replace(" ", "_").replace(".", "_"),
), ),
) )

28
homeassistant/components/sfr_box/strings.json
View File

@ -13,5 +13,33 @@
"abort": { "abort": {
"already_configured": "[%key:common::config_flow::abort::already_configured_device%]" "already_configured": "[%key:common::config_flow::abort::already_configured_device%]"
} }
},
"entity": {
"sensor": {
"line_status": {
"state": {
"no_defect": "No Defect",
"of_frame": "Of Frame",
"loss_of_signal": "Loss Of Signal",
"loss_of_power": "Loss Of Power",
"loss_of_signal_quality": "Loss Of Signal Quality",
"unknown": "Unknown"
}
},
"training": {
"state": {
"idle": "Idle",
"g_994_training": "G.994 Training",
"g_992_started": "G.992 Started",
"g_922_channel_analysis": "G.922 Channel Analysis",
"g_992_message_exchange": "G.992 Message Exchange",
"g_993_started": "G.993 Started",
"g_993_channel_analysis": "G.993 Channel Analysis",
"g_993_message_exchange": "G.993 Message Exchange",
"showtime": "Showtime",
"unknown": "Unknown"
}
}
}
} }
} }

28
homeassistant/components/sfr_box/translations/en.json
View File

@ -14,5 +14,33 @@
} }
} }
} }
},
"entity": {
"sensor": {
"line_status": {
"state": {
"no_defect": "No Defect",
"of_frame": "Of Frame",
"loss_of_signal": "Loss Of Signal",
"loss_of_power": "Loss Of Power",
"loss_of_signal_quality": "Loss Of Signal Quality",
"unknown": "Unknown"
}
},
"training": {
"state": {
"idle":"Idle",
"g_994_training":"G.994 Training",
"g_992_started":"G.992 Started",
"g_922_channel_analysis":"G.922 Channel Analysis",
"g_992_message_exchange":"G.992 Message Exchange",
"g_993_started":"G.993 Started",
"g_993_channel_analysis":"G.993 Channel Analysis",
"g_993_message_exchange":"G.993 Message Exchange",
"showtime":"Showtime",
"unknown":"Unknown"
}
}
}
} }
} }