jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 19:27:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential MQTT discovery race condition (#17208)

Browse Source 
* Fix potential MQTT discovery race condition

* Rename data key
This commit is contained in:
Otto Winter 2018-10-08 10:59:43 +02:00 committed by Paulus Schoutsen
parent ee5e1fa355
commit 3f498bd042
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/mqtt/discovery.py
View File

@ -4,6 +4,7 @@ Support for MQTT discovery.
For more details about this component, please refer to the documentation at For more details about this component, please refer to the documentation at
https://home-assistant.io/components/mqtt/#discovery https://home-assistant.io/components/mqtt/#discovery
""" """
import asyncio
import json import json
import logging import logging
import re import re
@ -51,6 +52,7 @@ CONFIG_ENTRY_PLATFORMS = {
} }
ALREADY_DISCOVERED = 'mqtt_discovered_components' ALREADY_DISCOVERED = 'mqtt_discovered_components'
DATA_CONFIG_ENTRY_LOCK = 'mqtt_config_entry_lock'
CONFIG_ENTRY_IS_SETUP = 'mqtt_config_entry_is_setup' CONFIG_ENTRY_IS_SETUP = 'mqtt_config_entry_is_setup'
MQTT_DISCOVERY_UPDATED = 'mqtt_discovery_updated_{}' MQTT_DISCOVERY_UPDATED = 'mqtt_discovery_updated_{}'
MQTT_DISCOVERY_NEW = 'mqtt_discovery_new_{}_{}' MQTT_DISCOVERY_NEW = 'mqtt_discovery_new_{}_{}'
@ -119,14 +121,16 @@ async def async_start(hass: HomeAssistantType, discovery_topic, hass_config,
return return
config_entries_key = '{}.{}'.format(component, platform) config_entries_key = '{}.{}'.format(component, platform)
async with hass.data[DATA_CONFIG_ENTRY_LOCK]:
if config_entries_key not in hass.data[CONFIG_ENTRY_IS_SETUP]: if config_entries_key not in hass.data[CONFIG_ENTRY_IS_SETUP]:
hass.data[CONFIG_ENTRY_IS_SETUP].add(config_entries_key)
await hass.config_entries.async_forward_entry_setup( await hass.config_entries.async_forward_entry_setup(
config_entry, component) config_entry, component)
hass.data[CONFIG_ENTRY_IS_SETUP].add(config_entries_key)
async_dispatcher_send(hass, MQTT_DISCOVERY_NEW.format( async_dispatcher_send(hass, MQTT_DISCOVERY_NEW.format(
component, platform), payload) component, platform), payload)
hass.data[DATA_CONFIG_ENTRY_LOCK] = asyncio.Lock()
hass.data[CONFIG_ENTRY_IS_SETUP] = set() hass.data[CONFIG_ENTRY_IS_SETUP] = set()
await mqtt.async_subscribe( await mqtt.async_subscribe(