jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-17 02:07:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always set pause feature on Music Assistant mediaplayers (#141686)

Browse Source
This commit is contained in:
Marcel van der Veldt 2025-03-29 18:39:59 +01:00 committed by Franck Nijhof
parent 3e0eb5ab2c
commit 405cbd6a00
No known key found for this signature in database
GPG Key ID: D62583BA8AB11CA3
2 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
homeassistant/components/music_assistant/media_player.py
View File

@ -94,6 +94,12 @@ SUPPORTED_FEATURES_BASE = (
| MediaPlayerEntityFeature.MEDIA_ENQUEUE | MediaPlayerEntityFeature.MEDIA_ENQUEUE
| MediaPlayerEntityFeature.MEDIA_ANNOUNCE | MediaPlayerEntityFeature.MEDIA_ANNOUNCE
| MediaPlayerEntityFeature.SEEK | MediaPlayerEntityFeature.SEEK
# we always add pause support,
# regardless if the underlying player actually natively supports pause
# because the MA behavior is to internally handle pause with stop
# (and a resume position) and we'd like to keep the UX consistent
# background info: https://github.com/home-assistant/core/issues/140118
| MediaPlayerEntityFeature.PAUSE
) )
QUEUE_OPTION_MAP = { QUEUE_OPTION_MAP = {
@ -697,8 +703,6 @@ class MusicAssistantPlayer(MusicAssistantEntity, MediaPlayerEntity):
supported_features = SUPPORTED_FEATURES_BASE supported_features = SUPPORTED_FEATURES_BASE
if PlayerFeature.SET_MEMBERS in self.player.supported_features: if PlayerFeature.SET_MEMBERS in self.player.supported_features:
supported_features |= MediaPlayerEntityFeature.GROUPING supported_features |= MediaPlayerEntityFeature.GROUPING
if PlayerFeature.PAUSE in self.player.supported_features:
supported_features |= MediaPlayerEntityFeature.PAUSE
if self.player.mute_control != PLAYER_CONTROL_NONE: if self.player.mute_control != PLAYER_CONTROL_NONE:
supported_features |= MediaPlayerEntityFeature.VOLUME_MUTE supported_features |= MediaPlayerEntityFeature.VOLUME_MUTE
if self.player.volume_control != PLAYER_CONTROL_NONE: if self.player.volume_control != PLAYER_CONTROL_NONE:

13
tests/components/music_assistant/test_media_player.py
View File

@ -694,19 +694,6 @@ async def test_media_player_supported_features(
assert state assert state
assert state.attributes["supported_features"] == expected_features assert state.attributes["supported_features"] == expected_features
# remove pause capability from player, trigger subscription callback
# and check if the supported features got updated
music_assistant_client.players._players[mass_player_id].supported_features.remove(
PlayerFeature.PAUSE
)
await trigger_subscription_callback(
hass, music_assistant_client, EventType.PLAYER_CONFIG_UPDATED, mass_player_id
)
expected_features &= ~MediaPlayerEntityFeature.PAUSE
state = hass.states.get(entity_id)
assert state
assert state.attributes["supported_features"] == expected_features
# remove grouping capability from player, trigger subscription callback # remove grouping capability from player, trigger subscription callback
# and check if the supported features got updated # and check if the supported features got updated
music_assistant_client.players._players[mass_player_id].supported_features.remove( music_assistant_client.players._players[mass_player_id].supported_features.remove(