jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-04-23 00:37:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Calculate Plum Lightpad brightness and glowIntensity correctly (#33352)

Browse Source 
* Plum Lightpad - glowIntensity is represented as a float/percentage
Calculate brightness from the glowIntensity instead of the glowIntensity from brightness.

* Renamed `_glowIntensity` to `_glow_intensity`

* Added Rounding, converting to an int, min and max boxing

* Added codeowners to the Plum Lightpad manifest.json
This commit is contained in:
Colin Harrington 2020-03-28 23:01:22 -05:00 committed by GitHub
parent d832ce0b26
commit 42cb5a5239
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CODEOWNERS
View File

@ -284,6 +284,7 @@ homeassistant/components/plaato/* @JohNan
homeassistant/components/plant/* @ChristianKuehnel
homeassistant/components/plex/* @jjlawren
homeassistant/components/plugwise/* @laetificat @CoMPaTech @bouwew
homeassistant/components/plum_lightpad/* @ColinHarrington
homeassistant/components/point/* @fredrike
homeassistant/components/powerwall/* @bdraco
homeassistant/components/proxmoxve/* @k4ds3

14
homeassistant/components/plum_lightpad/light.py
View File

@ -97,7 +97,7 @@ class GlowRing(Light):
self._name = f"{lightpad.friendly_name} Glow Ring"
self._state = lightpad.glow_enabled
self._brightness = lightpad.glow_intensity * 255.0
self._glow_intensity = lightpad.glow_intensity
self._red = lightpad.glow_color["red"]
self._green = lightpad.glow_color["green"]
@ -112,7 +112,7 @@ class GlowRing(Light):
config = event["changes"]
self._state = config["glowEnabled"]
self._brightness = config["glowIntensity"] * 255.0
self._glow_intensity = config["glowIntensity"]
self._red = config["glowColor"]["red"]
self._green = config["glowColor"]["green"]
@ -138,12 +138,12 @@ class GlowRing(Light):
@property
def brightness(self) -> int:
"""Return the brightness of this switch between 0..255."""
return self._brightness
return min(max(int(round(self._glow_intensity * 255, 0)), 0), 255)
@property
def glow_intensity(self):
"""Brightness in float form."""
return self._brightness / 255.0
return self._glow_intensity
@property
def is_on(self) -> bool:
@ -163,7 +163,8 @@ class GlowRing(Light):
async def async_turn_on(self, **kwargs):
"""Turn the light on."""
if ATTR_BRIGHTNESS in kwargs:
await self._lightpad.set_config({"glowIntensity": kwargs[ATTR_BRIGHTNESS]})
brightness_pct = kwargs[ATTR_BRIGHTNESS] / 255.0
await self._lightpad.set_config({"glowIntensity": brightness_pct})
elif ATTR_HS_COLOR in kwargs:
hs_color = kwargs[ATTR_HS_COLOR]
red, green, blue = color_util.color_hs_to_RGB(*hs_color)
@ -174,6 +175,7 @@ class GlowRing(Light):
async def async_turn_off(self, **kwargs):
"""Turn the light off."""
if ATTR_BRIGHTNESS in kwargs:
await self._lightpad.set_config({"glowIntensity": kwargs[ATTR_BRIGHTNESS]})
brightness_pct = kwargs[ATTR_BRIGHTNESS] / 255.0
await self._lightpad.set_config({"glowIntensity": brightness_pct})
else:
await self._lightpad.set_config({"glowEnabled": False})

2
homeassistant/components/plum_lightpad/manifest.json
View File

@ -4,5 +4,5 @@
"documentation": "https://www.home-assistant.io/integrations/plum_lightpad",
"requirements": ["plumlightpad==0.0.11"],
"dependencies": [],
"codeowners": []
"codeowners": ["@ColinHarrington"]
}