jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 01:37:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

huawei_lte: support out of range values in default sensor formatter (#26052)

Browse Source 
* Update sensor.py

Change regexp to cope with out of range values, ie "rssi" : ">=-51dBm".

* Add tests for format_default

* Fix black formatting
This commit is contained in:
flebourse 2019-08-19 19:34:33 +02:00 committed by Ville Skyttä
parent a38bdc4deb
commit 45aec2ea40
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/huawei_lte/sensor.py
View File

@ -137,7 +137,9 @@ def format_default(value):
unit = None
if value is not None:
# Clean up value and infer unit, e.g. -71dBm, 15 dB
match = re.match(r"(?P<value>.+?)\s*(?P<unit>[a-zA-Z]+)\s*$", str(value))
match = re.match(
r"([>=<]*)(?P<value>.+?)\s*(?P<unit>[a-zA-Z]+)\s*$", str(value)
)
if match:
try:
value = float(match.group("value"))

14
tests/components/huawei_lte/test_sensor.py Normal file
View File

@ -0,0 +1,14 @@
"""Huawei LTE sensor tests."""
import pytest
from homeassistant.components.huawei_lte import sensor
@pytest.mark.parametrize(
("value", "expected"),
(("-71 dBm", (-71, "dBm")), ("15dB", (15, "dB")), (">=-51dBm", (-51, "dBm"))),
)
def test_format_default(value, expected):
"""Test that default formatter copes with expected values."""
assert sensor.format_default(value) == expected