jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-21 12:17:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Renault charging power sensor (#81412)

Browse Source
This commit is contained in:
epenet 2022-11-02 18:07:51 +01:00 committed by GitHub
parent e1be63f26c
commit 466365c8de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
homeassistant/components/renault/sensor.py
View File

@ -23,7 +23,6 @@ from homeassistant.components.sensor import (
) )
from homeassistant.config_entries import ConfigEntry from homeassistant.config_entries import ConfigEntry
from homeassistant.const import ( from homeassistant.const import (
ELECTRIC_CURRENT_AMPERE,
ENERGY_KILO_WATT_HOUR, ENERGY_KILO_WATT_HOUR,
LENGTH_KILOMETERS, LENGTH_KILOMETERS,
PERCENTAGE, PERCENTAGE,
@ -189,17 +188,22 @@ SENSOR_TYPES: tuple[RenaultSensorEntityDescription[Any], ...] = (
state_class=SensorStateClass.MEASUREMENT, state_class=SensorStateClass.MEASUREMENT,
), ),
RenaultSensorEntityDescription( RenaultSensorEntityDescription(
# For vehicles that DO NOT report charging power in watts, this seems to
# correspond to the maximum power that would be admissible by the car based
# on the battery state, regardless of the type of charger.
key="charging_power", key="charging_power",
condition_lambda=lambda a: not a.details.reports_charging_power_in_watts(), condition_lambda=lambda a: not a.details.reports_charging_power_in_watts(),
coordinator="battery", coordinator="battery",
data_key="chargingInstantaneousPower", data_key="chargingInstantaneousPower",
device_class=SensorDeviceClass.CURRENT, device_class=SensorDeviceClass.POWER,
entity_class=RenaultSensor[KamereonVehicleBatteryStatusData], entity_class=RenaultSensor[KamereonVehicleBatteryStatusData],
name="Charging power", name="Admissible charging power",
native_unit_of_measurement=ELECTRIC_CURRENT_AMPERE, native_unit_of_measurement=POWER_KILO_WATT,
state_class=SensorStateClass.MEASUREMENT, state_class=SensorStateClass.MEASUREMENT,
), ),
RenaultSensorEntityDescription( RenaultSensorEntityDescription(
# For vehicles that DO report charging power in watts, this is the power
# effectively being transferred to the car.
key="charging_power", key="charging_power",
condition_lambda=lambda a: a.details.reports_charging_power_in_watts(), condition_lambda=lambda a: a.details.reports_charging_power_in_watts(),
coordinator="battery", coordinator="battery",

13
tests/components/renault/const.py
View File

@ -27,7 +27,6 @@ from homeassistant.const import (
ATTR_UNIT_OF_MEASUREMENT, ATTR_UNIT_OF_MEASUREMENT,
CONF_PASSWORD, CONF_PASSWORD,
CONF_USERNAME, CONF_USERNAME,
ELECTRIC_CURRENT_AMPERE,
ENERGY_KILO_WATT_HOUR, ENERGY_KILO_WATT_HOUR,
LENGTH_KILOMETERS, LENGTH_KILOMETERS,
PERCENTAGE, PERCENTAGE,
@ -398,12 +397,12 @@ MOCK_VEHICLES = {
ATTR_UNIQUE_ID: "vf1aaaaa555777999_charge_state", ATTR_UNIQUE_ID: "vf1aaaaa555777999_charge_state",
}, },
{ {
ATTR_DEVICE_CLASS: SensorDeviceClass.CURRENT, ATTR_DEVICE_CLASS: SensorDeviceClass.POWER,
ATTR_ENTITY_ID: "sensor.reg_number_charging_power", ATTR_ENTITY_ID: "sensor.reg_number_admissible_charging_power",
ATTR_STATE: STATE_UNKNOWN, ATTR_STATE: STATE_UNKNOWN,
ATTR_STATE_CLASS: SensorStateClass.MEASUREMENT, ATTR_STATE_CLASS: SensorStateClass.MEASUREMENT,
ATTR_UNIQUE_ID: "vf1aaaaa555777999_charging_power", ATTR_UNIQUE_ID: "vf1aaaaa555777999_charging_power",
ATTR_UNIT_OF_MEASUREMENT: ELECTRIC_CURRENT_AMPERE, ATTR_UNIT_OF_MEASUREMENT: POWER_KILO_WATT,
}, },
{ {
ATTR_ENTITY_ID: "sensor.reg_number_charging_remaining_time", ATTR_ENTITY_ID: "sensor.reg_number_charging_remaining_time",
@ -617,12 +616,12 @@ MOCK_VEHICLES = {
ATTR_UNIQUE_ID: "vf1aaaaa555777123_charge_state", ATTR_UNIQUE_ID: "vf1aaaaa555777123_charge_state",
}, },
{ {
ATTR_DEVICE_CLASS: SensorDeviceClass.CURRENT, ATTR_DEVICE_CLASS: SensorDeviceClass.POWER,
ATTR_ENTITY_ID: "sensor.reg_number_charging_power", ATTR_ENTITY_ID: "sensor.reg_number_admissible_charging_power",
ATTR_STATE: "27.0", ATTR_STATE: "27.0",
ATTR_STATE_CLASS: SensorStateClass.MEASUREMENT, ATTR_STATE_CLASS: SensorStateClass.MEASUREMENT,
ATTR_UNIQUE_ID: "vf1aaaaa555777123_charging_power", ATTR_UNIQUE_ID: "vf1aaaaa555777123_charging_power",
ATTR_UNIT_OF_MEASUREMENT: ELECTRIC_CURRENT_AMPERE, ATTR_UNIT_OF_MEASUREMENT: POWER_KILO_WATT,
}, },
{ {
ATTR_ENTITY_ID: "sensor.reg_number_charging_remaining_time", ATTR_ENTITY_ID: "sensor.reg_number_charging_remaining_time",