jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix velbus dimming control (#33139)

Browse Source 
* Fix light control

* Optimize conversion logic
This commit is contained in:
brefra 2020-03-24 21:58:50 +01:00 committed by GitHub
parent 3f4a7ec396
commit 46985bba0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
homeassistant/components/velbus/light.py
View File

@ -64,7 +64,7 @@ class VelbusLight(VelbusEntity, Light):
@property @property
def brightness(self): def brightness(self):
"""Return the brightness of the light.""" """Return the brightness of the light."""
return self._module.get_dimmer_state(self._channel) return int((self._module.get_dimmer_state(self._channel) * 255) / 100)
def turn_on(self, **kwargs): def turn_on(self, **kwargs):
"""Instruct the Velbus light to turn on.""" """Instruct the Velbus light to turn on."""
@ -80,10 +80,15 @@ class VelbusLight(VelbusEntity, Light):
attr, *args = "set_led_state", self._channel, "on" attr, *args = "set_led_state", self._channel, "on"
else: else:
if ATTR_BRIGHTNESS in kwargs: if ATTR_BRIGHTNESS in kwargs:
# Make sure a low but non-zero value is not rounded down to zero
if kwargs[ATTR_BRIGHTNESS] == 0:
brightness = 0
else:
brightness = max(int((kwargs[ATTR_BRIGHTNESS] * 100) / 255), 1)
attr, *args = ( attr, *args = (
"set_dimmer_state", "set_dimmer_state",
self._channel, self._channel,
kwargs[ATTR_BRIGHTNESS], brightness,
kwargs.get(ATTR_TRANSITION, 0), kwargs.get(ATTR_TRANSITION, 0),
) )
else: else: