From 46c2bd0eb072c8898ec22626aabfafb8c0e976fb Mon Sep 17 00:00:00 2001 From: Robert Svensson Date: Wed, 23 Feb 2022 20:26:46 +0100 Subject: [PATCH] Tweak UniFi client tracker (#67129) --- .../components/unifi/device_tracker.py | 1 - tests/components/unifi/test_device_tracker.py | 21 ++----------------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/homeassistant/components/unifi/device_tracker.py b/homeassistant/components/unifi/device_tracker.py index b241e07fc89..60ea4b3284b 100644 --- a/homeassistant/components/unifi/device_tracker.py +++ b/homeassistant/components/unifi/device_tracker.py @@ -198,7 +198,6 @@ class UniFiClientTracker(UniFiClient, ScannerEntity): elif ( self.client.last_updated == SOURCE_DATA - and self._last_seen != self.client.last_seen and self.is_wired == self.client.is_wired ): self._last_seen = self.client.last_seen diff --git a/tests/components/unifi/test_device_tracker.py b/tests/components/unifi/test_device_tracker.py index b490d43fffd..532f19c35ae 100644 --- a/tests/components/unifi/test_device_tracker.py +++ b/tests/components/unifi/test_device_tracker.py @@ -54,23 +54,6 @@ async def test_tracked_wireless_clients( assert len(hass.states.async_entity_ids(TRACKER_DOMAIN)) == 1 assert hass.states.get("device_tracker.client").state == STATE_NOT_HOME - # State change signalling works without events - - mock_unifi_websocket( - data={ - "meta": {"message": MESSAGE_CLIENT}, - "data": [client], - } - ) - await hass.async_block_till_done() - - client_state = hass.states.get("device_tracker.client") - assert client_state.state == STATE_NOT_HOME - assert client_state.attributes["ip"] == "10.0.0.1" - assert client_state.attributes["mac"] == "00:00:00:00:00:01" - assert client_state.attributes["hostname"] == "client" - assert client_state.attributes["host_name"] == "client" - # Updated timestamp marks client as home client["last_seen"] = dt_util.as_timestamp(dt_util.utcnow()) @@ -93,7 +76,7 @@ async def test_tracked_wireless_clients( assert hass.states.get("device_tracker.client").state == STATE_NOT_HOME - # Same timestamp again means client is away + # Same timestamp doesn't explicitly mark client as away mock_unifi_websocket( data={ @@ -103,7 +86,7 @@ async def test_tracked_wireless_clients( ) await hass.async_block_till_done() - assert hass.states.get("device_tracker.client").state == STATE_NOT_HOME + assert hass.states.get("device_tracker.client").state == STATE_HOME async def test_tracked_clients(