From 47801e7350eeb7a4cbe36668d9033433d629b3bd Mon Sep 17 00:00:00 2001 From: uvjustin <46082645+uvjustin@users.noreply.github.com> Date: Sun, 17 May 2020 21:23:44 +0800 Subject: [PATCH] Abort forked-daapd zeroconf flow if version < 27 (#35709) * Change MediaPlayerDevice to MediaPlayerEntity * Abort zeroconf if mtd-version < 27.0 --- homeassistant/components/forked_daapd/config_flow.py | 2 +- tests/components/forked_daapd/test_config_flow.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/forked_daapd/config_flow.py b/homeassistant/components/forked_daapd/config_flow.py index dda11171fe8..697c3f0c7ac 100644 --- a/homeassistant/components/forked_daapd/config_flow.py +++ b/homeassistant/components/forked_daapd/config_flow.py @@ -158,7 +158,7 @@ class ForkedDaapdFlowHandler(config_entries.ConfigFlow, domain=DOMAIN): """Prepare configuration for a discovered forked-daapd device.""" if not ( discovery_info.get("properties") - and discovery_info["properties"].get("mtd-version") + and float(discovery_info["properties"].get("mtd-version", 0)) >= 27.0 and discovery_info["properties"].get("Machine Name") ): return self.async_abort(reason="not_forked_daapd") diff --git a/tests/components/forked_daapd/test_config_flow.py b/tests/components/forked_daapd/test_config_flow.py index b0b484d8943..b97cc07009c 100644 --- a/tests/components/forked_daapd/test_config_flow.py +++ b/tests/components/forked_daapd/test_config_flow.py @@ -103,7 +103,7 @@ async def test_zeroconf_updates_title(hass, config_entry): discovery_info = { "host": "192.168.1.1", "port": 23, - "properties": {"mtd-version": 1, "Machine Name": "zeroconf_test"}, + "properties": {"mtd-version": 27.0, "Machine Name": "zeroconf_test"}, } result = await hass.config_entries.flow.async_init( DOMAIN, context={"source": SOURCE_ZEROCONF}, data=discovery_info @@ -143,7 +143,7 @@ async def test_config_flow_zeroconf_valid(hass): "host": "192.168.1.1", "port": 23, "properties": { - "mtd-version": 1, + "mtd-version": 27.0, "Machine Name": "zeroconf_test", "Machine ID": "5E55EEFF", },