jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-25 06:07:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

KNX Cover: Use absolute tilt position if available (#96192)

Browse Source
This commit is contained in:
Matthias Alphart 2023-07-09 12:00:51 +02:00 committed by GitHub
parent 6758292655
commit 479015244d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 61 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
homeassistant/components/knx/cover.py
View File

@ -163,11 +163,17 @@ class KNXCover(KnxEntity, CoverEntity):
async def async_open_cover_tilt(self, **kwargs: Any) -> None: async def async_open_cover_tilt(self, **kwargs: Any) -> None:
"""Open the cover tilt.""" """Open the cover tilt."""
await self._device.set_short_up() if self._device.angle.writable:
await self._device.set_angle(0)
else:
await self._device.set_short_up()
async def async_close_cover_tilt(self, **kwargs: Any) -> None: async def async_close_cover_tilt(self, **kwargs: Any) -> None:
"""Close the cover tilt.""" """Close the cover tilt."""
await self._device.set_short_down() if self._device.angle.writable:
await self._device.set_angle(100)
else:
await self._device.set_short_down()
async def async_stop_cover_tilt(self, **kwargs: Any) -> None: async def async_stop_cover_tilt(self, **kwargs: Any) -> None:
"""Stop the cover tilt.""" """Stop the cover tilt."""

59
tests/components/knx/test_cover.py
View File

@ -19,8 +19,6 @@ async def test_cover_basic(hass: HomeAssistant, knx: KNXTestKit) -> None:
CoverSchema.CONF_MOVE_SHORT_ADDRESS: "1/0/1", CoverSchema.CONF_MOVE_SHORT_ADDRESS: "1/0/1",
CoverSchema.CONF_POSITION_STATE_ADDRESS: "1/0/2", CoverSchema.CONF_POSITION_STATE_ADDRESS: "1/0/2",
CoverSchema.CONF_POSITION_ADDRESS: "1/0/3", CoverSchema.CONF_POSITION_ADDRESS: "1/0/3",
CoverSchema.CONF_ANGLE_STATE_ADDRESS: "1/0/4",
CoverSchema.CONF_ANGLE_ADDRESS: "1/0/5",
} }
} }
) )
@ -28,10 +26,8 @@ async def test_cover_basic(hass: HomeAssistant, knx: KNXTestKit) -> None:
# read position state address and angle state address # read position state address and angle state address
await knx.assert_read("1/0/2") await knx.assert_read("1/0/2")
await knx.assert_read("1/0/4")
# StateUpdater initialize state # StateUpdater initialize state
await knx.receive_response("1/0/2", (0x0F,)) await knx.receive_response("1/0/2", (0x0F,))
await knx.receive_response("1/0/4", (0x30,))
events.clear() events.clear()
# open cover # open cover
@ -82,6 +78,32 @@ async def test_cover_basic(hass: HomeAssistant, knx: KNXTestKit) -> None:
assert len(events) == 1 assert len(events) == 1
events.pop() events.pop()
async def test_cover_tilt_absolute(hass: HomeAssistant, knx: KNXTestKit) -> None:
"""Test KNX cover tilt."""
await knx.setup_integration(
{
CoverSchema.PLATFORM: {
CONF_NAME: "test",
CoverSchema.CONF_MOVE_LONG_ADDRESS: "1/0/0",
CoverSchema.CONF_MOVE_SHORT_ADDRESS: "1/0/1",
CoverSchema.CONF_POSITION_STATE_ADDRESS: "1/0/2",
CoverSchema.CONF_POSITION_ADDRESS: "1/0/3",
CoverSchema.CONF_ANGLE_STATE_ADDRESS: "1/0/4",
CoverSchema.CONF_ANGLE_ADDRESS: "1/0/5",
}
}
)
events = async_capture_events(hass, "state_changed")
# read position state address and angle state address
await knx.assert_read("1/0/2")
await knx.assert_read("1/0/4")
# StateUpdater initialize state
await knx.receive_response("1/0/2", (0x0F,))
await knx.receive_response("1/0/4", (0x30,))
events.clear()
# set cover tilt position # set cover tilt position
await hass.services.async_call( await hass.services.async_call(
"cover", "cover",
@ -102,7 +124,7 @@ async def test_cover_basic(hass: HomeAssistant, knx: KNXTestKit) -> None:
await hass.services.async_call( await hass.services.async_call(
"cover", "close_cover_tilt", target={"entity_id": "cover.test"}, blocking=True "cover", "close_cover_tilt", target={"entity_id": "cover.test"}, blocking=True
) )
await knx.assert_write("1/0/1", True) await knx.assert_write("1/0/5", (0xFF,))
assert len(events) == 1 assert len(events) == 1
events.pop() events.pop()
@ -111,4 +133,29 @@ async def test_cover_basic(hass: HomeAssistant, knx: KNXTestKit) -> None:
await hass.services.async_call( await hass.services.async_call(
"cover", "open_cover_tilt", target={"entity_id": "cover.test"}, blocking=True "cover", "open_cover_tilt", target={"entity_id": "cover.test"}, blocking=True
) )
await knx.assert_write("1/0/1", False) await knx.assert_write("1/0/5", (0x00,))
async def test_cover_tilt_move_short(hass: HomeAssistant, knx: KNXTestKit) -> None:
"""Test KNX cover tilt."""
await knx.setup_integration(
{
CoverSchema.PLATFORM: {
CONF_NAME: "test",
CoverSchema.CONF_MOVE_LONG_ADDRESS: "1/0/0",
CoverSchema.CONF_MOVE_SHORT_ADDRESS: "1/0/1",
}
}
)
# close cover tilt
await hass.services.async_call(
"cover", "close_cover_tilt", target={"entity_id": "cover.test"}, blocking=True
)
await knx.assert_write("1/0/1", 1)
# open cover tilt
await hass.services.async_call(
"cover", "open_cover_tilt", target={"entity_id": "cover.test"}, blocking=True
)
await knx.assert_write("1/0/1", 0)