jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 02:37:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed invalid response when sending a test-request from Locative iOS app (#5179)

Browse Source
This commit is contained in:
Sander de Leeuw 2017-01-05 09:05:39 +01:00 committed by Johann Kellerman
parent 2f907696f3
commit 497a1c84b5
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
homeassistant/components/device_tracker/locative.py
View File

@ -63,18 +63,18 @@ class LocativeView(HomeAssistantView):
return ('Device id not specified.', return ('Device id not specified.',
HTTP_UNPROCESSABLE_ENTITY) HTTP_UNPROCESSABLE_ENTITY)
if 'id' not in data:
_LOGGER.error('Location id not specified.')
return ('Location id not specified.',
HTTP_UNPROCESSABLE_ENTITY)
if 'trigger' not in data: if 'trigger' not in data:
_LOGGER.error('Trigger is not specified.') _LOGGER.error('Trigger is not specified.')
return ('Trigger is not specified.', return ('Trigger is not specified.',
HTTP_UNPROCESSABLE_ENTITY) HTTP_UNPROCESSABLE_ENTITY)
if 'id' not in data and data['trigger'] != 'test':
_LOGGER.error('Location id not specified.')
return ('Location id not specified.',
HTTP_UNPROCESSABLE_ENTITY)
device = data['device'].replace('-', '') device = data['device'].replace('-', '')
location_name = data['id'].lower() location_name = data.get('id', data['trigger']).lower()
direction = data['trigger'] direction = data['trigger']
gps_location = (data[ATTR_LATITUDE], data[ATTR_LONGITUDE]) gps_location = (data[ATTR_LATITUDE], data[ATTR_LONGITUDE])

7
tests/components/device_tracker/test_locative.py
View File

@ -108,6 +108,13 @@ class TestLocative(unittest.TestCase):
req = requests.get(_url(copy)) req = requests.get(_url(copy))
self.assertEqual(200, req.status_code) self.assertEqual(200, req.status_code)
# Test message, no location
copy = data.copy()
copy['trigger'] = 'test'
del copy['id']
req = requests.get(_url(copy))
self.assertEqual(200, req.status_code)
# Unknown trigger # Unknown trigger
copy = data.copy() copy = data.copy()
copy['trigger'] = 'foobar' copy['trigger'] = 'foobar'