From 49982ac83c18a47aff6d8952eae4c7ab9b826210 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Sun, 28 Feb 2016 00:59:28 -0800 Subject: [PATCH] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7f63274df03..c654a8c75e6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,7 @@ **Related issue (if applicable):** # + **Example entry for `configuration.yaml` (if applicable):** ```yaml @@ -9,17 +10,17 @@ **Checklist:** -- [ ] Local tests with `tox` ran successfully. -- [ ] No CI failures. **Your PR cannot be merged unless CI is green!** +- [ ] Local tests with `tox` run successfully. +- [ ] TravisCI does not fail. **Your PR cannot be merged unless CI is green!** - [ ] [Fork is up to date][fork] and was rebased on the `dev` branch before creating the PR. +- [ ] Commits have been [squashed][squash]. - If code communicates with devices: - - [ ] 3rd party library/libraries for communication is/are added as dependencies via the `REQUIREMENTS` variable ([example][ex-requir]). - - [ ] 3rd party dependencies are imported inside functions that use them ([example][ex-import]). - - [ ] `requirements_all.txt` is up-to-date, `script/gen_requirements_all.py` ran and the updated file is included in the PR. + - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]). + - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]). + - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`. - [ ] New files were added to `.coveragerc`. -- If the code does not depend on external Python module: - - [ ] Tests to verify that the code works are included. -- [ ] [Commits will be squashed][squash] when the PR is ready to be merged. +- If the code does not interact with devices: + - [ ] Tests have been added to verify that the new code works. [fork]: http://stackoverflow.com/a/7244456 [squash]: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit