jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-24 05:37:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix consider-using-with warnings in core tests (#119606)

Browse Source
This commit is contained in:
epenet 2024-06-13 16:59:40 +02:00 committed by GitHub
parent 384fa53cc0
commit 49b28cca62
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
tests/test_block_async_io.py
View File

@ -212,8 +212,11 @@ async def test_protect_loop_importlib_import_module_in_integration(
async def test_protect_loop_open(caplog: pytest.LogCaptureFixture) -> None:
"""Test open of a file in /proc is not reported."""
block_async_io.enable()
with contextlib.suppress(FileNotFoundError):
open("/proc/does_not_exist", encoding="utf8").close()
with (
contextlib.suppress(FileNotFoundError),
open("/proc/does_not_exist", encoding="utf8"),
):
pass
assert "Detected blocking call to open with args" not in caplog.text
@ -221,8 +224,11 @@ async def test_protect_open(caplog: pytest.LogCaptureFixture) -> None:
"""Test opening a file in the event loop logs."""
with patch.object(block_async_io, "_IN_TESTS", False):
block_async_io.enable()
with contextlib.suppress(FileNotFoundError):
open("/config/data_not_exist", encoding="utf8").close()
with (
contextlib.suppress(FileNotFoundError),
open("/config/data_not_exist", encoding="utf8"),
):
pass
assert "Detected blocking call to open with args" in caplog.text
@ -250,8 +256,8 @@ async def test_protect_open_path(path: Any, caplog: pytest.LogCaptureFixture) ->
"""Test opening a file by path in the event loop logs."""
with patch.object(block_async_io, "_IN_TESTS", False):
block_async_io.enable()
with contextlib.suppress(FileNotFoundError):
open(path, encoding="utf8").close()
with contextlib.suppress(FileNotFoundError), open(path, encoding="utf8"):
pass
assert "Detected blocking call to open with args" in caplog.text
@ -331,7 +337,10 @@ async def test_open_calls_ignored_in_tests(caplog: pytest.LogCaptureFixture) ->
"""Test opening a file in tests is ignored."""
assert block_async_io._IN_TESTS
block_async_io.enable()
with contextlib.suppress(FileNotFoundError):
open("/config/data_not_exist", encoding="utf8").close()
with (
contextlib.suppress(FileNotFoundError),
open("/config/data_not_exist", encoding="utf8"),
):
pass
assert "Detected blocking call to open with args" not in caplog.text