jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-14 08:47:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix rain retrival for OWM (#39566)

Browse Source 
As documented in the OWM API (https://openweathermap.org/api/one-call-api), rain and snow are reported on a 1h basis:

current.rain
    current.rain.1h (where available) Rain volume for last hour, mm
current.snow
    current.snow.1h (where available) Snow volume for last hour, mm
This commit is contained in:
Hendrik Schröter 2020-09-03 06:16:38 +00:00 committed by GitHub
parent 65e53b8251
commit 49daf57c54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
homeassistant/components/openweathermap/sensor.py
View File

@ -165,15 +165,16 @@ class OpenWeatherMapSensor(Entity):
self._state = data.get_clouds() self._state = data.get_clouds()
elif self.type == "rain": elif self.type == "rain":
rain = data.get_rain() rain = data.get_rain()
if "3h" in rain: if "1h" in rain:
self._state = round(rain["3h"], 0) self._state = round(rain["1h"], 0)
self._unit_of_measurement = "mm" self._unit_of_measurement = "mm"
else: else:
self._state = "not raining" self._state = "not raining"
self._unit_of_measurement = "" self._unit_of_measurement = ""
elif self.type == "snow": elif self.type == "snow":
if data.get_snow(): snow = data.get_snow()
self._state = round(data.get_snow(), 0) if "1h" in snow:
self._state = round(snow["1h"], 0)
self._unit_of_measurement = "mm" self._unit_of_measurement = "mm"
else: else:
self._state = "not snowing" self._state = "not snowing"

10
homeassistant/components/openweathermap/weather.py
View File

@ -203,18 +203,16 @@ class OpenWeatherMapWeather(WeatherEntity):
} }
) )
else: else:
rain = entry.get_rain().get("1h")
if rain is not None:
rain = round(rain, 1)
data.append( data.append(
{ {
ATTR_FORECAST_TIME: entry.get_reference_time("unix") * 1000, ATTR_FORECAST_TIME: entry.get_reference_time("unix") * 1000,
ATTR_FORECAST_TEMP: entry.get_temperature("celsius").get( ATTR_FORECAST_TEMP: entry.get_temperature("celsius").get(
"temp" "temp"
), ),
ATTR_FORECAST_PRECIPITATION: ( ATTR_FORECAST_PRECIPITATION: rain,
round(entry.get_rain().get("3h"), 1)
if entry.get_rain().get("3h") is not None
and (round(entry.get_rain().get("3h"), 1) > 0)
else None
),
ATTR_FORECAST_CONDITION: [ ATTR_FORECAST_CONDITION: [
k k
for k, v in CONDITION_CLASSES.items() for k, v in CONDITION_CLASSES.items()