jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-22 12:47:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Validate translations for custom components (#34519)

Browse Source
This commit is contained in:
Paulus Schoutsen 2020-04-22 06:24:45 -07:00 committed by GitHub
parent e002c84eba
commit 4a08c65205
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 44 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
script/hassfest/translations.py
View File

@ -1,5 +1,6 @@
"""Validate integration translation files.""" """Validate integration translation files."""
from functools import partial from functools import partial
from itertools import chain
import json import json
import logging import logging
import re import re
@ -210,34 +211,61 @@ def validate_translation_file(config: Config, integration: Integration, all_stri
if config.specific_integrations: if config.specific_integrations:
check_translations_directory_name(integration) check_translations_directory_name(integration)
strings_file = integration.path / "strings.json" strings_files = [integration.path / "strings.json"]
# Also validate translations for custom integrations
if config.specific_integrations:
# Only English needs to be always complete
strings_files.append(integration.path / "translations/en.json")
references = [] references = []
if strings_file.is_file(): if integration.domain == "auth":
strings = json.loads(strings_file.read_text()) strings_schema = gen_auth_schema(config, integration)
elif integration.domain == "onboarding":
strings_schema = ONBOARDING_SCHEMA
else:
strings_schema = gen_strings_schema(config, integration)
if integration.domain == "auth": for strings_file in strings_files:
schema = gen_auth_schema(config, integration) if not strings_file.is_file():
elif integration.domain == "onboarding": continue
schema = ONBOARDING_SCHEMA
else: name = str(strings_file.relative_to(integration.path))
schema = gen_strings_schema(config, integration)
try: try:
schema(strings) strings = json.loads(strings_file.read_text())
except ValueError as err:
integration.add_error("translations", f"Invalid JSON in {name}: {err}")
continue
try:
strings_schema(strings)
except vol.Invalid as err: except vol.Invalid as err:
integration.add_error( integration.add_error(
"translations", f"Invalid strings.json: {humanize_error(strings, err)}" "translations", f"Invalid {name}: {humanize_error(strings, err)}"
) )
else: else:
find_references(strings, "strings.json", references) if strings_file.name == "strings.json":
find_references(strings, name, references)
for path in integration.path.glob("strings.*.json"): platform_string_schema = gen_platform_strings_schema(config, integration)
strings = json.loads(path.read_text()) platform_strings = [integration.path.glob("strings.*.json")]
schema = gen_platform_strings_schema(config, integration)
if config.specific_integrations:
platform_strings.append(integration.path.glob("translations/*.en.json"))
for path in chain(*platform_strings):
name = str(path.relative_to(integration.path))
try: try:
schema(strings) strings = json.loads(path.read_text())
except ValueError as err:
integration.add_error("translations", f"Invalid JSON in {name}: {err}")
continue
try:
platform_string_schema(strings)
except vol.Invalid as err: except vol.Invalid as err:
msg = f"Invalid {path.name}: {humanize_error(strings, err)}" msg = f"Invalid {path.name}: {humanize_error(strings, err)}"
if config.specific_integrations: if config.specific_integrations: