Downloader downloads file in seperate thread now so it doesn't block bus queue

This commit is contained in:
Paulus Schoutsen 2014-02-14 11:57:42 -08:00
parent c735e32361
commit 4ab362531f

View File

@ -7,6 +7,7 @@ Provides functionality to download files.
import os import os
import logging import logging
import re import re
import threading
import homeassistant.util as util import homeassistant.util as util
@ -15,6 +16,7 @@ DOMAIN = "downloader"
SERVICE_DOWNLOAD_FILE = "download_file" SERVICE_DOWNLOAD_FILE = "download_file"
# pylint: disable=too-many-branches
def setup(bus, download_path): def setup(bus, download_path):
""" Listens for download events to download files. """ """ Listens for download events to download files. """
@ -36,11 +38,19 @@ def setup(bus, download_path):
return False return False
def _download_file(service): def download_file(service):
""" Downloads file specified in the url. """ """ Starts thread to download file specified in the url. """
if not 'url' in service.data:
logger.error("Service called but 'url' parameter not specified.")
return
def do_download():
""" Downloads the file. """
try: try:
req = requests.get(service.data['url'], stream=True) url = service.data['url']
req = requests.get(url, stream=True)
if req.status_code == 200: if req.status_code == 200:
filename = None filename = None
@ -52,7 +62,8 @@ def setup(bus, download_path):
filename = match[0].strip("'\" ") filename = match[0].strip("'\" ")
if not filename: if not filename:
filename = os.path.basename(service.data['url']).strip() filename = os.path.basename(
url).strip()
if not filename: if not filename:
filename = "ha_download" filename = "ha_download"
@ -63,7 +74,8 @@ def setup(bus, download_path):
path, ext = os.path.splitext(os.path.join(download_path, path, ext = os.path.splitext(os.path.join(download_path,
filename)) filename))
# If file exist append a number. We test filename, filename_2.. # If file exist append a number.
# We test filename, filename_2..
tries = 1 tries = 1
final_path = path + ext final_path = path + ext
while os.path.isfile(final_path): while os.path.isfile(final_path):
@ -72,17 +84,22 @@ def setup(bus, download_path):
final_path = path + "_{}".format(tries) + ext final_path = path + "_{}".format(tries) + ext
logger.info("{} -> {}".format( logger.info("{} -> {}".format(
service.data['url'], final_path)) url, final_path))
with open(final_path, 'wb') as fil: with open(final_path, 'wb') as fil:
for chunk in req.iter_content(1024): for chunk in req.iter_content(1024):
fil.write(chunk) fil.write(chunk)
logger.info("Downloading of {} done".format(
url))
except requests.exceptions.ConnectionError: except requests.exceptions.ConnectionError:
logger.exception("ConnectionError occured for {}". logger.exception("ConnectionError occured for {}".
format(service.data['url'])) format(url))
threading.Thread(target=do_download).start()
bus.register_service(DOMAIN, SERVICE_DOWNLOAD_FILE, bus.register_service(DOMAIN, SERVICE_DOWNLOAD_FILE,
_download_file) download_file)
return True return True