From 4ad998378f636934487e54fa6952d486d7939ede Mon Sep 17 00:00:00 2001 From: Alan Fischer Date: Tue, 20 Jun 2017 07:26:19 -0600 Subject: [PATCH] Fixed iTach command parsing with empty data (#8104) * Fixed iTach command parsing with empty data * Switched to using format --- homeassistant/components/remote/itach.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/remote/itach.py b/homeassistant/components/remote/itach.py index e5a013a5dcf..9feb2d1141d 100644 --- a/homeassistant/components/remote/itach.py +++ b/homeassistant/components/remote/itach.py @@ -62,10 +62,16 @@ def setup_platform(hass, config, add_devices, discovery_info=None): name = data.get(CONF_NAME) modaddr = int(data.get(CONF_MODADDR, 1)) connaddr = int(data.get(CONF_CONNADDR, 1)) - cmddata = "" + cmddatas = "" for cmd in data.get(CONF_COMMANDS): - cmddata += cmd[CONF_NAME] + "\n" + cmd[CONF_DATA] + "\n" - itachip2ir.addDevice(name, modaddr, connaddr, cmddata) + cmdname = cmd[CONF_NAME].strip() + if not cmdname: + cmdname = '""' + cmddata = cmd[CONF_DATA].strip() + if not cmddata: + cmddata = '""' + cmddatas += "{}\n{}\n".format(cmdname, cmddata) + itachip2ir.addDevice(name, modaddr, connaddr, cmddatas) devices.append(ITachIP2IRRemote(itachip2ir, name)) add_devices(devices, True) return True