jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 03:07:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

modbus update, add error log instead of AttributeError exception (#3517)

Browse Source
This commit is contained in:
Per Sandström 2016-09-27 05:46:34 +02:00 committed by Paulus Schoutsen
parent 041c92699a
commit 4c45e92116
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/sensor/modbus.py
View File

@ -93,6 +93,12 @@ class ModbusRegisterSensor(Entity):
self._register, self._register,
self._count) self._count)
val = 0 val = 0
if not result:
_LOGGER.error(
'No response from modbus slave %s register %s',
self._slave,
self._register)
return
for i, res in enumerate(result.registers): for i, res in enumerate(result.registers):
val += res * (2**(i*16)) val += res * (2**(i*16))
self._value = format( self._value = format(

6
homeassistant/components/switch/modbus.py
View File

@ -72,4 +72,10 @@ class ModbusCoilSwitch(ToggleEntity):
def update(self): def update(self):
"""Update the state of the switch.""" """Update the state of the switch."""
result = modbus.HUB.read_coils(self._slave, self._coil, 1) result = modbus.HUB.read_coils(self._slave, self._coil, 1)
if not result:
_LOGGER.error(
'No response from modbus slave %s coil %s',
self._slave,
self._coil)
return
self._is_on = bool(result.bits[0]) self._is_on = bool(result.bits[0])