From 4d7802215ca5a4b1273b3d00481ddc52f3176bb6 Mon Sep 17 00:00:00 2001 From: Ben Thomas Date: Tue, 28 May 2024 04:51:51 +0100 Subject: [PATCH] Fix rooms not being matched correctly in sharkiq.clean_room (#118277) * Fix rooms not being matched correctly in sharkiq.clean_room * Update sharkiq tests to account for new room matching logic --- homeassistant/components/sharkiq/vacuum.py | 1 + tests/components/sharkiq/test_vacuum.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/sharkiq/vacuum.py b/homeassistant/components/sharkiq/vacuum.py index 3f77cd3d478..8401feabcd8 100644 --- a/homeassistant/components/sharkiq/vacuum.py +++ b/homeassistant/components/sharkiq/vacuum.py @@ -212,6 +212,7 @@ class SharkVacuumEntity(CoordinatorEntity[SharkIqUpdateCoordinator], StateVacuum """Clean specific rooms.""" rooms_to_clean = [] valid_rooms = self.available_rooms or [] + rooms = [room.replace("_", " ").title() for room in rooms] for room in rooms: if room in valid_rooms: rooms_to_clean.append(room) diff --git a/tests/components/sharkiq/test_vacuum.py b/tests/components/sharkiq/test_vacuum.py index c72ad1a8c36..a3d03ecf4f7 100644 --- a/tests/components/sharkiq/test_vacuum.py +++ b/tests/components/sharkiq/test_vacuum.py @@ -236,7 +236,6 @@ async def test_device_properties( @pytest.mark.parametrize( ("room_list", "exception"), [ - (["KITCHEN"], exceptions.ServiceValidationError), (["KITCHEN", "MUD_ROOM", "DOG HOUSE"], exceptions.ServiceValidationError), (["Office"], exceptions.ServiceValidationError), ([], MultipleInvalid),