jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 17:57:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix authorization header in cors (#21662)

Browse Source 
* Fix authorization headers in cors

* Use aiohttp authorization header instead of custom const
This commit is contained in:
Paul Bottein 2019-03-09 19:00:10 +01:00 committed by Paulus Schoutsen
parent fc81826763
commit 4d9cf15c45
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/http/cors.py
View File

@ -1,5 +1,5 @@
"""Provide CORS support for the HTTP component.""" """Provide CORS support for the HTTP component."""
from aiohttp.hdrs import ACCEPT, CONTENT_TYPE, ORIGIN from aiohttp.hdrs import ACCEPT, CONTENT_TYPE, ORIGIN, AUTHORIZATION
from homeassistant.const import ( from homeassistant.const import (
HTTP_HEADER_HA_AUTH, HTTP_HEADER_X_REQUESTED_WITH) HTTP_HEADER_HA_AUTH, HTTP_HEADER_X_REQUESTED_WITH)
@ -7,7 +7,7 @@ from homeassistant.core import callback
ALLOWED_CORS_HEADERS = [ ALLOWED_CORS_HEADERS = [
ORIGIN, ACCEPT, HTTP_HEADER_X_REQUESTED_WITH, CONTENT_TYPE, ORIGIN, ACCEPT, HTTP_HEADER_X_REQUESTED_WITH, CONTENT_TYPE,
HTTP_HEADER_HA_AUTH] HTTP_HEADER_HA_AUTH, AUTHORIZATION]
@callback @callback

14
tests/components/http/test_cors.py
View File

@ -7,11 +7,14 @@ from aiohttp.hdrs import (
ACCESS_CONTROL_ALLOW_HEADERS, ACCESS_CONTROL_ALLOW_HEADERS,
ACCESS_CONTROL_REQUEST_HEADERS, ACCESS_CONTROL_REQUEST_HEADERS,
ACCESS_CONTROL_REQUEST_METHOD, ACCESS_CONTROL_REQUEST_METHOD,
AUTHORIZATION,
ORIGIN ORIGIN
) )
import pytest import pytest
from homeassistant.const import HTTP_HEADER_HA_AUTH from homeassistant.const import (
HTTP_HEADER_HA_AUTH
)
from homeassistant.setup import async_setup_component from homeassistant.setup import async_setup_component
from homeassistant.components.http.cors import setup_cors from homeassistant.components.http.cors import setup_cors
from homeassistant.components.http.view import HomeAssistantView from homeassistant.components.http.view import HomeAssistantView
@ -84,6 +87,15 @@ async def test_cors_requests(client):
assert req.headers[ACCESS_CONTROL_ALLOW_ORIGIN] == \ assert req.headers[ACCESS_CONTROL_ALLOW_ORIGIN] == \
TRUSTED_ORIGIN TRUSTED_ORIGIN
# With auth token in headers
req = await client.get('/', headers={
AUTHORIZATION: 'Bearer some-token',
ORIGIN: TRUSTED_ORIGIN
})
assert req.status == 200
assert req.headers[ACCESS_CONTROL_ALLOW_ORIGIN] == \
TRUSTED_ORIGIN
async def test_cors_preflight_allowed(client): async def test_cors_preflight_allowed(client):
"""Test cross origin resource sharing preflight (OPTIONS) request.""" """Test cross origin resource sharing preflight (OPTIONS) request."""