jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 23:27:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

LIRC: Responded to some code review requests but not the big one

Browse Source
This commit is contained in:
ntouran 2016-05-22 22:19:10 -07:00
parent 80e60efd8f
commit 4e5b5f2204
3 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
homeassistant/components/sensor/lirc.py
View File

@ -6,9 +6,9 @@ in the .lintrc file which can be interpreted in home-assistant to
trigger various actions. trigger various actions.
Sending signals to other IR receivers can be accomplished with the Sending signals to other IR receivers can be accomplished with the
shell_command component and the irsend command. shell_command component and the irsend command for now.
""" """
# pylint: disable=import-error
import threading import threading
import time import time
import logging import logging
@ -16,8 +16,7 @@ import logging
from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity import Entity
from homeassistant.const import EVENT_HOMEASSISTANT_STOP from homeassistant.const import EVENT_HOMEASSISTANT_STOP
LIRC = None REQUIREMENTS = ['python-lirc>=1.2.1']
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
ICON = 'mdi:remote' ICON = 'mdi:remote'
@ -27,13 +26,12 @@ def setup_platform(hass, config, add_devices, discovery_info=None):
# Perform safe import of third-party python-lirc module # Perform safe import of third-party python-lirc module
try: try:
import lirc import lirc
global LIRC
LIRC = lirc
except ImportError: except ImportError:
_LOGGER.error("You are missing a required dependency: python-lirc.") _LOGGER.error("You are missing a required dependency: python-lirc.")
return False return False
LIRC.init('home-assistant', blocking=False) # blocking=True gives unexpected behavior (multiple responses for 1 press)
lirc.init('home-assistant', blocking=False)
sensor = LircSensor() sensor = LircSensor()
add_devices([sensor]) add_devices([sensor])
@ -44,7 +42,7 @@ class LircSensor(Entity):
"""Sensor entity for LIRC.""" """Sensor entity for LIRC."""
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):
"""Contruct a LircSensor entity.""" """Construct a LircSensor entity."""
_LOGGER.info('Initializing LIRC sensor') _LOGGER.info('Initializing LIRC sensor')
Entity.__init__(self, *args, **kwargs) Entity.__init__(self, *args, **kwargs)
self.last_key_pressed = '' self.last_key_pressed = ''
@ -66,7 +64,7 @@ class LircSensor(Entity):
self.last_key_pressed = new_state self.last_key_pressed = new_state
self.update_ha_state() self.update_ha_state()
def stop(self, event): def stop(self, _event):
"""Kill the helper thread on stop.""" """Kill the helper thread on stop."""
_LOGGER.info('Ending LIRC interface thread') _LOGGER.info('Ending LIRC interface thread')
self._lirc_interface.stopped.set() self._lirc_interface.stopped.set()
@ -89,8 +87,9 @@ class LircInterface(threading.Thread):
def run(self): def run(self):
"""Main loop of LIRC interface thread.""" """Main loop of LIRC interface thread."""
import lirc
while not self.stopped.isSet(): while not self.stopped.isSet():
code = LIRC.nextcode() # list; empty if no buttons pressed code = lirc.nextcode() # list; empty if no buttons pressed
# interpret result from python-lirc # interpret result from python-lirc
if code: if code:

3
requirements_all.txt
View File

@ -262,6 +262,9 @@ pysnmp==4.2.5
# homeassistant.components.sensor.forecast # homeassistant.components.sensor.forecast
python-forecastio==1.3.4 python-forecastio==1.3.4
# homeassistant.components.sensor.lirc
# python-lirc>=1.2.1
# homeassistant.components.media_player.mpd # homeassistant.components.media_player.mpd
python-mpd2==0.5.5 python-mpd2==0.5.5

1
script/gen_requirements_all.py
View File

@ -13,6 +13,7 @@ COMMENT_REQUIREMENTS = [
'fritzconnection', 'fritzconnection',
'pybluez', 'pybluez',
'bluepy', 'bluepy',
'python-lirc',
] ]