jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-21 20:27:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve hvac_mode compatibility of vicare (#66454)

Browse Source
This commit is contained in:
Hans Oischinger 2022-06-23 11:34:34 +02:00 committed by GitHub
parent f91a222034
commit 4ee92f3953
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
homeassistant/components/vicare/climate.py
View File

@ -71,19 +71,13 @@ VICARE_TEMP_HEATING_MIN = 3
VICARE_TEMP_HEATING_MAX = 37 VICARE_TEMP_HEATING_MAX = 37
VICARE_TO_HA_HVAC_HEATING = { VICARE_TO_HA_HVAC_HEATING = {
VICARE_MODE_DHW: HVACMode.OFF,
VICARE_MODE_HEATING: HVACMode.HEAT,
VICARE_MODE_DHWANDHEATING: HVACMode.AUTO,
VICARE_MODE_DHWANDHEATINGCOOLING: HVACMode.AUTO,
VICARE_MODE_FORCEDREDUCED: HVACMode.OFF, VICARE_MODE_FORCEDREDUCED: HVACMode.OFF,
VICARE_MODE_FORCEDNORMAL: HVACMode.HEAT,
VICARE_MODE_OFF: HVACMode.OFF, VICARE_MODE_OFF: HVACMode.OFF,
} VICARE_MODE_DHW: HVACMode.OFF,
VICARE_MODE_DHWANDHEATINGCOOLING: HVACMode.AUTO,
HA_TO_VICARE_HVAC_HEATING = { VICARE_MODE_DHWANDHEATING: HVACMode.AUTO,
HVACMode.HEAT: VICARE_MODE_FORCEDNORMAL, VICARE_MODE_HEATING: HVACMode.AUTO,
HVACMode.OFF: VICARE_MODE_FORCEDREDUCED, VICARE_MODE_FORCEDNORMAL: HVACMode.HEAT,
HVACMode.AUTO: VICARE_MODE_DHWANDHEATING,
} }
VICARE_TO_HA_PRESET_HEATING = { VICARE_TO_HA_PRESET_HEATING = {
@ -276,19 +270,41 @@ class ViCareClimate(ClimateEntity):
def set_hvac_mode(self, hvac_mode: HVACMode) -> None: def set_hvac_mode(self, hvac_mode: HVACMode) -> None:
"""Set a new hvac mode on the ViCare API.""" """Set a new hvac mode on the ViCare API."""
vicare_mode = HA_TO_VICARE_HVAC_HEATING.get(hvac_mode) if "vicare_modes" not in self._attributes:
raise ValueError("Cannot set hvac mode when vicare_modes are not known")
vicare_mode = self.vicare_mode_from_hvac_mode(hvac_mode)
if vicare_mode is None: if vicare_mode is None:
raise ValueError( raise ValueError(f"Cannot set invalid hvac mode: {hvac_mode}")
f"Cannot set invalid vicare mode: {hvac_mode} / {vicare_mode}"
)
_LOGGER.debug("Setting hvac mode to %s / %s", hvac_mode, vicare_mode) _LOGGER.debug("Setting hvac mode to %s / %s", hvac_mode, vicare_mode)
self._circuit.setMode(vicare_mode) self._circuit.setMode(vicare_mode)
def vicare_mode_from_hvac_mode(self, hvac_mode):
"""Return the corresponding vicare mode for an hvac_mode."""
if "vicare_modes" not in self._attributes:
return None
supported_modes = self._attributes["vicare_modes"]
for key, value in VICARE_TO_HA_HVAC_HEATING.items():
if key in supported_modes and value == hvac_mode:
return key
return None
@property @property
def hvac_modes(self) -> list[HVACMode]: def hvac_modes(self) -> list[HVACMode]:
"""Return the list of available hvac modes.""" """Return the list of available hvac modes."""
return list(HA_TO_VICARE_HVAC_HEATING) if "vicare_modes" not in self._attributes:
return []
supported_modes = self._attributes["vicare_modes"]
hvac_modes = []
for key, value in VICARE_TO_HA_HVAC_HEATING.items():
if value in hvac_modes:
continue
if key in supported_modes:
hvac_modes.append(value)
return hvac_modes
@property @property
def hvac_action(self) -> HVACAction: def hvac_action(self) -> HVACAction: