From 4fde63b1fb3970db47bfce66f5a95f8980766063 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Tue, 10 Dec 2013 08:08:57 -0800 Subject: [PATCH] Bugfix in turning lights on at sun set --- .idea/.name | 1 + .idea/encodings.xml | 5 + .idea/home-assistant.iml | 16 ++ .idea/misc.xml | 5 + .idea/modules.xml | 9 + .idea/scopes/scope_settings.xml | 5 + .idea/vcs.xml | 7 + .idea/workspace.xml | 484 ++++++++++++++++++++++++++++++++ homeassistant/actors.py | 2 +- pep8.txt | 15 + pylint.txt | 123 ++++++++ 11 files changed, 671 insertions(+), 1 deletion(-) create mode 100644 .idea/.name create mode 100644 .idea/encodings.xml create mode 100644 .idea/home-assistant.iml create mode 100644 .idea/misc.xml create mode 100644 .idea/modules.xml create mode 100644 .idea/scopes/scope_settings.xml create mode 100644 .idea/vcs.xml create mode 100644 .idea/workspace.xml create mode 100644 pep8.txt create mode 100644 pylint.txt diff --git a/.idea/.name b/.idea/.name new file mode 100644 index 00000000000..61b96a042f7 --- /dev/null +++ b/.idea/.name @@ -0,0 +1 @@ +home-assistant \ No newline at end of file diff --git a/.idea/encodings.xml b/.idea/encodings.xml new file mode 100644 index 00000000000..e206d70d859 --- /dev/null +++ b/.idea/encodings.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/.idea/home-assistant.iml b/.idea/home-assistant.iml new file mode 100644 index 00000000000..ddae08c5b0b --- /dev/null +++ b/.idea/home-assistant.iml @@ -0,0 +1,16 @@ + + + + + + + + + + + + + diff --git a/.idea/misc.xml b/.idea/misc.xml new file mode 100644 index 00000000000..6d4142548ff --- /dev/null +++ b/.idea/misc.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/.idea/modules.xml b/.idea/modules.xml new file mode 100644 index 00000000000..e2df14ffd63 --- /dev/null +++ b/.idea/modules.xml @@ -0,0 +1,9 @@ + + + + + + + + + diff --git a/.idea/scopes/scope_settings.xml b/.idea/scopes/scope_settings.xml new file mode 100644 index 00000000000..922003b8433 --- /dev/null +++ b/.idea/scopes/scope_settings.xml @@ -0,0 +1,5 @@ + + + + \ No newline at end of file diff --git a/.idea/vcs.xml b/.idea/vcs.xml new file mode 100644 index 00000000000..c80f2198b5f --- /dev/null +++ b/.idea/vcs.xml @@ -0,0 +1,7 @@ + + + + + + + diff --git a/.idea/workspace.xml b/.idea/workspace.xml new file mode 100644 index 00000000000..0130a6c78b7 --- /dev/null +++ b/.idea/workspace.xml @@ -0,0 +1,484 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + 1384050152631 + 1384050152631 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/homeassistant/actors.py b/homeassistant/actors.py index 32b3e16d9f0..756f65367ec 100644 --- a/homeassistant/actors.py +++ b/homeassistant/actors.py @@ -65,7 +65,7 @@ def setup_device_light_triggers(bus, statemachine): # Calculates the time when to start fading lights in when sun sets time_for_light_before_sun_set = lambda: \ (next_sun_setting(statemachine) - LIGHT_TRANSITION_TIME * - len(statemachine)) + len(light_ids)) # pylint: disable=unused-argument def handle_sun_rising(category, old_state, new_state): diff --git a/pep8.txt b/pep8.txt new file mode 100644 index 00000000000..a23bcfcd04a --- /dev/null +++ b/pep8.txt @@ -0,0 +1,15 @@ +homeassistant/httpinterface.py:268:21: E126 continuation line over-indented for hanging indent +homeassistant/httpinterface.py:302:21: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:326:21: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:357:18: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:364:21: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:375:21: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:389:21: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:392:20: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:396:18: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:400:22: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:438:21: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:452:21: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:455:20: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:459:18: E127 continuation line over-indented for visual indent +homeassistant/httpinterface.py:463:22: E127 continuation line over-indented for visual indent diff --git a/pylint.txt b/pylint.txt new file mode 100644 index 00000000000..4cad44fd5a8 --- /dev/null +++ b/pylint.txt @@ -0,0 +1,123 @@ +************* Module homeassistant.httpinterface +W:647, 0: TODO: correct header for mime-type and caching (fixme) +E:216,29: Instance of 'str' has no 'match' member (but some types could not be inferred) (maybe-no-member) +************* Module homeassistant.packages.pychromecast.example +C: 9, 0: Invalid constant name "host" (invalid-name) +C: 18, 0: Invalid constant name "cast" (invalid-name) +************* Module homeassistant.packages.pychromecast.pychromecast +W:211,11: Catching too general exception Exception (broad-except) + + +Report +====== +1285 statements analysed. + +Duplication +----------- + ++-------------------------+------+---------+-----------+ +| |now |previous |difference | ++=========================+======+=========+===========+ +|nb duplicated lines |0 |0 |= | ++-------------------------+------+---------+-----------+ +|percent duplicated lines |0.000 |0.000 |= | ++-------------------------+------+---------+-----------+ + + + +External dependencies +--------------------- +:: + + ephem (homeassistant.observers) + phue (homeassistant.actors) + pykeyboard (homeassistant.actors) + requests (homeassistant.remote,homeassistant.actors,homeassistant.packages.pychromecast.pychromecast,homeassistant.test,homeassistant.observers) + + + +Raw metrics +----------- + ++----------+-------+------+---------+-----------+ +|type |number |% |previous |difference | ++==========+=======+======+=========+===========+ +|code |1564 |61.31 |1559 |+5.00 | ++----------+-------+------+---------+-----------+ +|docstring |625 |24.50 |625 |= | ++----------+-------+------+---------+-----------+ +|comment |150 |5.88 |150 |= | ++----------+-------+------+---------+-----------+ +|empty |212 |8.31 |212 |= | ++----------+-------+------+---------+-----------+ + + + +Messages by category +-------------------- + ++-----------+-------+---------+-----------+ +|type |number |previous |difference | ++===========+=======+=========+===========+ +|convention |2 |2 |= | ++-----------+-------+---------+-----------+ +|refactor |0 |0 |= | ++-----------+-------+---------+-----------+ +|warning |2 |3 |-1.00 | ++-----------+-------+---------+-----------+ +|error |1 |1 |= | ++-----------+-------+---------+-----------+ + + + +% errors / warnings by module +----------------------------- + ++-------------------------------------------------+-------+--------+---------+-----------+ +|module |error |warning |refactor |convention | ++=================================================+=======+========+=========+===========+ +|homeassistant.httpinterface |100.00 |50.00 |0.00 |0.00 | ++-------------------------------------------------+-------+--------+---------+-----------+ +|homeassistant.packages.pychromecast.pychromecast |0.00 |50.00 |0.00 |0.00 | ++-------------------------------------------------+-------+--------+---------+-----------+ + + + +Messages +-------- + ++-----------+------------+ +|message id |occurrences | ++===========+============+ +|C0103 |2 | ++-----------+------------+ +|W0703 |1 | ++-----------+------------+ +|W0511 |1 | ++-----------+------------+ +|E1103 |1 | ++-----------+------------+ + + + +Global evaluation +----------------- +Your code has been rated at 9.93/10 (previous run: 9.92/10, +0.01) + +Statistics by type +------------------ + ++---------+-------+-----------+-----------+------------+---------+ +|type |number |old number |difference |%documented |%badname | ++=========+=======+===========+===========+============+=========+ +|module |12 |12 |= |100.00 |0.00 | ++---------+-------+-----------+-----------+------------+---------+ +|class |17 |17 |= |100.00 |0.00 | ++---------+-------+-----------+-----------+------------+---------+ +|method |97 |97 |= |100.00 |12.37 | ++---------+-------+-----------+-----------+------------+---------+ +|function |66 |66 |= |100.00 |0.00 | ++---------+-------+-----------+-----------+------------+---------+ + + +