jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 10:47:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve foscam library exception support (#11701)

Browse Source 
* Improve foscam library exception support

Catches foscam exceptions that otherwise pollute the log. Many of these exception can safely be ignored

* Fixed line length

Fixed line length

* Changed exception and log handling

changed logging and catched only the TypeError effecting the library

* Removed unused var

Removed var

* Fix remaining issue
This commit is contained in:
i-am-shodan 2018-01-25 22:47:53 +00:00 committed by Fabian Affolter
parent 0db9c04f21
commit 502ebd2a31
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
homeassistant/components/camera/foscam.py
View File

@ -44,6 +44,8 @@ class FoscamCam(Camera):
def __init__(self, device_info): def __init__(self, device_info):
"""Initialize a Foscam camera.""" """Initialize a Foscam camera."""
from libpyfoscam import FoscamCamera
super(FoscamCam, self).__init__() super(FoscamCam, self).__init__()
ip_address = device_info.get(CONF_IP) ip_address = device_info.get(CONF_IP)
@ -53,10 +55,8 @@ class FoscamCam(Camera):
self._name = device_info.get(CONF_NAME) self._name = device_info.get(CONF_NAME)
self._motion_status = False self._motion_status = False
from libpyfoscam import FoscamCamera self._foscam_session = FoscamCamera(
ip_address, port, self._username, self._password, verbose=False)
self._foscam_session = FoscamCamera(ip_address, port, self._username,
self._password, verbose=False)
def camera_image(self): def camera_image(self):
"""Return a still image response from the camera.""" """Return a still image response from the camera."""
@ -75,20 +75,20 @@ class FoscamCam(Camera):
def enable_motion_detection(self): def enable_motion_detection(self):
"""Enable motion detection in camera.""" """Enable motion detection in camera."""
ret, err = self._foscam_session.enable_motion_detection() try:
if ret == FOSCAM_COMM_ERROR: ret = self._foscam_session.enable_motion_detection()
_LOGGER.debug("Unable to communicate with Foscam Camera: %s", err) self._motion_status = ret == FOSCAM_COMM_ERROR
self._motion_status = True except TypeError:
else: _LOGGER.debug("Communication problem")
self._motion_status = False self._motion_status = False
def disable_motion_detection(self): def disable_motion_detection(self):
"""Disable motion detection.""" """Disable motion detection."""
ret, err = self._foscam_session.disable_motion_detection() try:
if ret == FOSCAM_COMM_ERROR: ret = self._foscam_session.disable_motion_detection()
_LOGGER.debug("Unable to communicate with Foscam Camera: %s", err) self._motion_status = ret == FOSCAM_COMM_ERROR
self._motion_status = True except TypeError:
else: _LOGGER.debug("Communication problem")
self._motion_status = False self._motion_status = False
@property @property