From 515bd18ddd72d4c857fd13432767a1baa02749de Mon Sep 17 00:00:00 2001 From: Kevin Worrel <37058192+dieselrabbit@users.noreply.github.com> Date: Tue, 15 Jun 2021 04:19:48 -0700 Subject: [PATCH] Don't create unsupported pump sensors (#51828) * Don't create unsupported pump sensors * Remove old code and simplify new statements. * Address notes --- homeassistant/components/screenlogic/sensor.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/screenlogic/sensor.py b/homeassistant/components/screenlogic/sensor.py index 2419ee46eed..1ad18298655 100644 --- a/homeassistant/components/screenlogic/sensor.py +++ b/homeassistant/components/screenlogic/sensor.py @@ -68,11 +68,17 @@ async def async_setup_entry(hass, config_entry, async_add_entities): # Pump sensors for pump_num, pump_data in coordinator.data[SL_DATA.KEY_PUMPS].items(): if pump_data["data"] != 0 and "currentWatts" in pump_data: - entities.extend( - ScreenLogicPumpSensor(coordinator, pump_num, pump_key) - for pump_key in pump_data - if pump_key in SUPPORTED_PUMP_SENSORS - ) + for pump_key in pump_data: + # Considerations for Intelliflow VF + if pump_data["pumpType"] == 1 and pump_key == "currentRPM": + continue + # Considerations for Intelliflow VS + if pump_data["pumpType"] == 2 and pump_key == "currentGPM": + continue + if pump_key in SUPPORTED_PUMP_SENSORS: + entities.append( + ScreenLogicPumpSensor(coordinator, pump_num, pump_key) + ) # IntelliChem sensors if equipment_flags & EQUIPMENT.FLAG_INTELLICHEM: