jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-21 20:27:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove temperature conversion - synology_dsm (#55214)

Browse Source
This commit is contained in:
Marc Mueller 2021-08-25 16:32:35 +02:00 committed by GitHub
parent 20d8c4da90
commit 53851cb1b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
homeassistant/components/synology_dsm/const.py
View File

@ -26,6 +26,7 @@ from homeassistant.const import (
DEVICE_CLASS_TEMPERATURE,
DEVICE_CLASS_TIMESTAMP,
PERCENTAGE,
TEMP_CELSIUS,
)
@ -287,7 +288,7 @@ STORAGE_VOL_SENSORS: dict[str, EntityInfo] = {
},
f"{SynoStorage.API_KEY}:volume_disk_temp_avg": {
ATTR_NAME: "Average Disk Temp",
ATTR_UNIT_OF_MEASUREMENT: None,
ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS,
ATTR_ICON: None,
ATTR_DEVICE_CLASS: DEVICE_CLASS_TEMPERATURE,
ENTITY_ENABLE: True,
@ -295,7 +296,7 @@ STORAGE_VOL_SENSORS: dict[str, EntityInfo] = {
},
f"{SynoStorage.API_KEY}:volume_disk_temp_max": {
ATTR_NAME: "Maximum Disk Temp",
ATTR_UNIT_OF_MEASUREMENT: None,
ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS,
ATTR_ICON: None,
ATTR_DEVICE_CLASS: DEVICE_CLASS_TEMPERATURE,
ENTITY_ENABLE: False,
@ -321,7 +322,7 @@ STORAGE_DISK_SENSORS: dict[str, EntityInfo] = {
},
f"{SynoStorage.API_KEY}:disk_temp": {
ATTR_NAME: "Temperature",
ATTR_UNIT_OF_MEASUREMENT: None,
ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS,
ATTR_ICON: None,
ATTR_DEVICE_CLASS: DEVICE_CLASS_TEMPERATURE,
ENTITY_ENABLE: True,
@ -332,7 +333,7 @@ STORAGE_DISK_SENSORS: dict[str, EntityInfo] = {
INFORMATION_SENSORS: dict[str, EntityInfo] = {
f"{SynoDSMInformation.API_KEY}:temperature": {
ATTR_NAME: "temperature",
ATTR_UNIT_OF_MEASUREMENT: None,
ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS,
ATTR_ICON: None,
ATTR_DEVICE_CLASS: DEVICE_CLASS_TEMPERATURE,
ENTITY_ENABLE: True,
@ -359,11 +360,3 @@ SURVEILLANCE_SWITCH: dict[str, EntityInfo] = {
ATTR_STATE_CLASS: None,
},
}
TEMP_SENSORS_KEYS = [
"volume_disk_temp_avg",
"volume_disk_temp_max",
"disk_temp",
"temperature",
]

14
homeassistant/components/synology_dsm/sensor.py
View File

@ -11,12 +11,9 @@ from homeassistant.const import (
DATA_MEGABYTES,
DATA_RATE_KILOBYTES_PER_SECOND,
DATA_TERABYTES,
PRECISION_TENTHS,
TEMP_CELSIUS,
)
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.temperature import display_temp
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator
from homeassistant.util.dt import utcnow
@ -30,7 +27,6 @@ from .const import (
STORAGE_DISK_SENSORS,
STORAGE_VOL_SENSORS,
SYNO_API,
TEMP_SENSORS_KEYS,
UTILISATION_SENSORS,
EntityInfo,
)
@ -92,8 +88,6 @@ class SynoDSMSensor(SynologyDSMBaseEntity):
@property
def native_unit_of_measurement(self) -> str | None:
"""Return the unit the value is expressed in."""
if self.entity_type in TEMP_SENSORS_KEYS:
return self.hass.config.units.temperature_unit
return self._unit
@ -143,10 +137,6 @@ class SynoDSMStorageSensor(SynologyDSMDeviceEntity, SynoDSMSensor, SensorEntity)
if self._unit == DATA_TERABYTES:
return round(attr / 1024.0 ** 4, 2)
# Temperature
if self.entity_type in TEMP_SENSORS_KEYS:
return display_temp(self.hass, attr, TEMP_CELSIUS, PRECISION_TENTHS)
return attr
@ -172,10 +162,6 @@ class SynoDSMInfoSensor(SynoDSMSensor, SensorEntity):
if attr is None:
return None
# Temperature
if self.entity_type in TEMP_SENSORS_KEYS:
return display_temp(self.hass, attr, TEMP_CELSIUS, PRECISION_TENTHS)
if self.entity_type == "uptime":
# reboot happened or entity creation
if self._previous_uptime is None or self._previous_uptime > attr: