From 54d048fb11e70ea26513dd34d547d2d39ca01f79 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Tue, 21 May 2024 10:01:13 +0200 Subject: [PATCH] Remove silver integrations from NO_DIAGNOSTICS (#117840) --- script/hassfest/manifest.py | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/script/hassfest/manifest.py b/script/hassfest/manifest.py index 2796b4d2eb2..4861c893a37 100644 --- a/script/hassfest/manifest.py +++ b/script/hassfest/manifest.py @@ -124,12 +124,10 @@ NO_DIAGNOSTICS = [ "hyperion", "modbus", "nightscout", - "point", "pvpc_hourly_pricing", "risco", "smarttub", "songpal", - "tellduslive", "vizio", "yeelight", ] @@ -385,12 +383,19 @@ def validate_manifest(integration: Integration, core_components_dir: Path) -> No f"{quality_scale} integration does not implement diagnostics", ) - if domain in NO_DIAGNOSTICS and (integration.path / "diagnostics.py").exists(): - integration.add_error( - "manifest", - "Implements diagnostics and can be " - "removed from NO_DIAGNOSTICS in script/hassfest/manifest.py", - ) + if domain in NO_DIAGNOSTICS: + if quality_scale and QualityScale[quality_scale.upper()] < QualityScale.GOLD: + integration.add_error( + "manifest", + "{quality_scale} integration should be " + "removed from NO_DIAGNOSTICS in script/hassfest/manifest.py", + ) + elif (integration.path / "diagnostics.py").exists(): + integration.add_error( + "manifest", + "Implements diagnostics and can be " + "removed from NO_DIAGNOSTICS in script/hassfest/manifest.py", + ) if not integration.core: validate_version(integration)