jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Modbus 100% test coverage (again) (#100482)

Browse Source
This commit is contained in:
jan iversen 2023-09-16 14:00:22 +02:00 committed by GitHub
parent 48dc81eff0
commit 568974fcc4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/components/modbus/conftest.py
View File

@ -136,7 +136,7 @@ async def mock_pymodbus_exception_fixture(hass, do_exception, mock_modbus):
@pytest.fixture(name="mock_pymodbus_return") @pytest.fixture(name="mock_pymodbus_return")
async def mock_pymodbus_return_fixture(hass, register_words, mock_modbus): async def mock_pymodbus_return_fixture(hass, register_words, mock_modbus):
"""Trigger update call with time_changed event.""" """Trigger update call with time_changed event."""
read_result = ReadResult(register_words) read_result = ReadResult(register_words) if register_words else None
mock_modbus.read_coils.return_value = read_result mock_modbus.read_coils.return_value = read_result
mock_modbus.read_discrete_inputs.return_value = read_result mock_modbus.read_discrete_inputs.return_value = read_result
mock_modbus.read_input_registers.return_value = read_result mock_modbus.read_input_registers.return_value = read_result

7
tests/components/modbus/test_init.py
View File

@ -40,6 +40,7 @@ from homeassistant.components.modbus.const import (
CALL_TYPE_WRITE_REGISTERS, CALL_TYPE_WRITE_REGISTERS,
CONF_BAUDRATE, CONF_BAUDRATE,
CONF_BYTESIZE, CONF_BYTESIZE,
CONF_CLOSE_COMM_ON_ERROR,
CONF_DATA_TYPE, CONF_DATA_TYPE,
CONF_DEVICE_ADDRESS, CONF_DEVICE_ADDRESS,
CONF_INPUT_TYPE, CONF_INPUT_TYPE,
@ -413,6 +414,12 @@ async def test_duplicate_entity_validator(do_config) -> None:
@pytest.mark.parametrize( @pytest.mark.parametrize(
"do_config", "do_config",
[ [
{
CONF_TYPE: TCP,
CONF_HOST: TEST_MODBUS_HOST,
CONF_PORT: TEST_PORT_TCP,
CONF_CLOSE_COMM_ON_ERROR: True,
},
{ {
CONF_TYPE: TCP, CONF_TYPE: TCP,
CONF_HOST: TEST_MODBUS_HOST, CONF_HOST: TEST_MODBUS_HOST,

20
tests/components/modbus/test_sensor.py
View File

@ -409,6 +409,17 @@ async def test_config_wrong_struct_sensor(
False, False,
"-1985229329", "-1985229329",
), ),
(
{
CONF_DATA_TYPE: DataType.INT32,
CONF_SCALE: 1,
CONF_OFFSET: 0,
CONF_PRECISION: 0,
},
[0x89AB],
False,
STATE_UNAVAILABLE,
),
( (
{ {
CONF_DATA_TYPE: DataType.UINT32, CONF_DATA_TYPE: DataType.UINT32,
@ -751,6 +762,15 @@ async def test_all_sensor(hass: HomeAssistant, mock_do_cycle, expected) -> None:
False, False,
["16909060", "67305985"], ["16909060", "67305985"],
), ),
(
{
CONF_VIRTUAL_COUNT: 2,
CONF_UNIQUE_ID: SLAVE_UNIQUE_ID,
},
[0x0102, 0x0304, 0x0403, 0x0201, 0x0403],
False,
[STATE_UNAVAILABLE, STATE_UNKNOWN, STATE_UNKNOWN],
),
( (
{ {
CONF_SLAVE_COUNT: 3, CONF_SLAVE_COUNT: 3,