From 56e07bb1f21090f4e300154b0e8f5cca75be642d Mon Sep 17 00:00:00 2001
From: Norbert Rittel <norbert@rittel.de>
Date: Mon, 28 Apr 2025 10:18:07 +0200
Subject: [PATCH] Use common state for "Fault", add recommended hyphen in
 `fronius` (#143812)

* Use common state for "Fault" in `fronius`

Also add a recommended hyphen to "self-consumption".

See Wiktionary: "Words derived from self- are usually formed with a hyphen. Using a hyphen is recommended by the U.S. Government Printing Office Style Manual."

* Update test_sensor.ambr
---
 homeassistant/components/fronius/strings.json       |  6 +++---
 tests/components/fronius/snapshots/test_sensor.ambr | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/homeassistant/components/fronius/strings.json b/homeassistant/components/fronius/strings.json
index 6635060dd1c..e37607452e3 100644
--- a/homeassistant/components/fronius/strings.json
+++ b/homeassistant/components/fronius/strings.json
@@ -317,11 +317,11 @@
       "state_message": {
         "name": "State message",
         "state": {
+          "fault": "[%key:common::state::fault%]",
+          "critical_fault": "Critical fault",
           "up_and_running": "Up and running",
           "keep_minimum_temperature": "Keep minimum temperature",
           "legionella_protection": "Legionella protection",
-          "critical_fault": "Critical fault",
-          "fault": "Fault",
           "boost_mode": "Boost mode"
         }
       },
@@ -362,7 +362,7 @@
         "name": "Relative autonomy"
       },
       "relative_self_consumption": {
-        "name": "Relative self consumption"
+        "name": "Relative self-consumption"
       },
       "capacity_maximum": {
         "name": "Maximum capacity"
diff --git a/tests/components/fronius/snapshots/test_sensor.ambr b/tests/components/fronius/snapshots/test_sensor.ambr
index 5384e9c6389..63d2c85986a 100644
--- a/tests/components/fronius/snapshots/test_sensor.ambr
+++ b/tests/components/fronius/snapshots/test_sensor.ambr
@@ -3179,7 +3179,7 @@
     }),
     'original_device_class': None,
     'original_icon': None,
-    'original_name': 'Relative self consumption',
+    'original_name': 'Relative self-consumption',
     'platform': 'fronius',
     'previous_unique_id': None,
     'supported_features': 0,
@@ -3191,7 +3191,7 @@
 # name: test_gen24[sensor.solarnet_relative_self_consumption-state]
   StateSnapshot({
     'attributes': ReadOnlyDict({
-      'friendly_name': 'SolarNet Relative self consumption',
+      'friendly_name': 'SolarNet Relative self-consumption',
       'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
       'unit_of_measurement': '%',
     }),
@@ -7163,7 +7163,7 @@
     }),
     'original_device_class': None,
     'original_icon': None,
-    'original_name': 'Relative self consumption',
+    'original_name': 'Relative self-consumption',
     'platform': 'fronius',
     'previous_unique_id': None,
     'supported_features': 0,
@@ -7175,7 +7175,7 @@
 # name: test_gen24_storage[sensor.solarnet_relative_self_consumption-state]
   StateSnapshot({
     'attributes': ReadOnlyDict({
-      'friendly_name': 'SolarNet Relative self consumption',
+      'friendly_name': 'SolarNet Relative self-consumption',
       'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
       'unit_of_measurement': '%',
     }),
@@ -10087,7 +10087,7 @@
     }),
     'original_device_class': None,
     'original_icon': None,
-    'original_name': 'Relative self consumption',
+    'original_name': 'Relative self-consumption',
     'platform': 'fronius',
     'previous_unique_id': None,
     'supported_features': 0,
@@ -10099,7 +10099,7 @@
 # name: test_primo_s0[sensor.solarnet_relative_self_consumption-state]
   StateSnapshot({
     'attributes': ReadOnlyDict({
-      'friendly_name': 'SolarNet Relative self consumption',
+      'friendly_name': 'SolarNet Relative self-consumption',
       'state_class': <SensorStateClass.MEASUREMENT: 'measurement'>,
       'unit_of_measurement': '%',
     }),