jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 18:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Random test fixes (#6195)

Browse Source 
* Store persistent errors in hass (speeds up tests)

* Fix sleepiq test dependency on test order

* Fix sleepiq validation
This commit is contained in:
Paulus Schoutsen 2017-02-23 21:44:47 -08:00 committed by GitHub
parent c940d26f07
commit 58eb32bce4
3 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
homeassistant/bootstrap.py
View File

@ -34,7 +34,7 @@ _LOGGER = logging.getLogger(__name__)
ATTR_COMPONENT = 'component' ATTR_COMPONENT = 'component'
ERROR_LOG_FILENAME = 'home-assistant.log' ERROR_LOG_FILENAME = 'home-assistant.log'
_PERSISTENT_ERRORS = {} DATA_PERSISTENT_ERRORS = 'bootstrap_persistent_errors'
HA_COMPONENT_URL = '[{}](https://home-assistant.io/components/{}/)' HA_COMPONENT_URL = '[{}](https://home-assistant.io/components/{}/)'
@ -601,9 +601,14 @@ def _async_persistent_notification(hass: core.HomeAssistant, component: str,
This method must be run in the event loop. This method must be run in the event loop.
""" """
_PERSISTENT_ERRORS[component] = _PERSISTENT_ERRORS.get(component) or link errors = hass.data.get(DATA_PERSISTENT_ERRORS)
if errors is None:
errors = hass.data[DATA_PERSISTENT_ERRORS] = {}
errors[component] = errors.get(component) or link
_lst = [HA_COMPONENT_URL.format(name.replace('_', '-'), name) _lst = [HA_COMPONENT_URL.format(name.replace('_', '-'), name)
if link else name for name, link in _PERSISTENT_ERRORS.items()] if link else name for name, link in errors.items()]
message = ('The following components and platforms could not be set up:\n' message = ('The following components and platforms could not be set up:\n'
'* ' + '\n* '.join(list(_lst)) + '\nPlease check your config') '* ' + '\n* '.join(list(_lst)) + '\nPlease check your config')
persistent_notification.async_create( persistent_notification.async_create(

2
homeassistant/components/sleepiq.py
View File

@ -39,7 +39,7 @@ _LOGGER = logging.getLogger(__name__)
DATA = None DATA = None
CONFIG_SCHEMA = vol.Schema({ CONFIG_SCHEMA = vol.Schema({
DOMAIN: vol.Schema({ vol.Required(DOMAIN): vol.Schema({
vol.Required(CONF_USERNAME): cv.string, vol.Required(CONF_USERNAME): cv.string,
vol.Required(CONF_PASSWORD): cv.string, vol.Required(CONF_PASSWORD): cv.string,
}), }),

8
tests/components/sensor/test_sleepiq.py
View File

@ -4,6 +4,7 @@ from unittest.mock import MagicMock
import requests_mock import requests_mock
from homeassistant.bootstrap import setup_component
from homeassistant.components.sensor import sleepiq from homeassistant.components.sensor import sleepiq
from tests.components.test_sleepiq import mock_responses from tests.components.test_sleepiq import mock_responses
@ -39,6 +40,13 @@ class TestSleepIQSensorSetup(unittest.TestCase):
"""Test for successfully setting up the SleepIQ platform.""" """Test for successfully setting up the SleepIQ platform."""
mock_responses(mock) mock_responses(mock)
assert setup_component(self.hass, 'sleepiq', {
'sleepiq': {
'username': '',
'password': '',
}
})
sleepiq.setup_platform(self.hass, sleepiq.setup_platform(self.hass,
self.config, self.config,
self.add_devices, self.add_devices,