jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 07:07:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve local calendar error logging when uploading invalid .ics files (#142891)

Browse Source
This commit is contained in:
Allen Porter 2025-04-13 17:42:24 -07:00 committed by GitHub
parent d91528648f
commit 5b8ca8d0ed
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
homeassistant/components/local_calendar/config_flow.py
View File

@ -97,8 +97,7 @@ class LocalCalendarConfigFlow(ConfigFlow, domain=DOMAIN):
user_input[CONF_ICS_FILE], user_input[CONF_ICS_FILE],
self.data[CONF_STORAGE_KEY], self.data[CONF_STORAGE_KEY],
) )
except HomeAssistantError as err: except InvalidIcsFile:
_LOGGER.debug("Error saving uploaded file: %s", err)
errors[CONF_ICS_FILE] = "invalid_ics_file" errors[CONF_ICS_FILE] = "invalid_ics_file"
else: else:
return self.async_create_entry( return self.async_create_entry(
@ -112,6 +111,10 @@ class LocalCalendarConfigFlow(ConfigFlow, domain=DOMAIN):
) )
class InvalidIcsFile(HomeAssistantError):
"""Error to indicate that the uploaded file is not a valid ICS file."""
def save_uploaded_ics_file( def save_uploaded_ics_file(
hass: HomeAssistant, uploaded_file_id: str, storage_key: str hass: HomeAssistant, uploaded_file_id: str, storage_key: str
): ):
@ -122,6 +125,10 @@ def save_uploaded_ics_file(
try: try:
CalendarStream.from_ics(ics) CalendarStream.from_ics(ics)
except CalendarParseError as err: except CalendarParseError as err:
raise HomeAssistantError("Failed to upload file: Invalid ICS file") from err _LOGGER.error("Error reading the calendar information: %s", err.message)
_LOGGER.debug(
"Additional calendar error detail: %s", str(err.detailed_error)
)
raise InvalidIcsFile("Failed to upload file: Invalid ICS file") from err
dest_path = Path(hass.config.path(STORAGE_PATH.format(key=storage_key))) dest_path = Path(hass.config.path(STORAGE_PATH.format(key=storage_key)))
shutil.move(file, dest_path) shutil.move(file, dest_path)

2
homeassistant/components/local_calendar/strings.json
View File

@ -17,7 +17,7 @@
"already_configured": "[%key:common::config_flow::abort::already_configured_service%]" "already_configured": "[%key:common::config_flow::abort::already_configured_service%]"
}, },
"error": { "error": {
"invalid_ics_file": "Invalid .ics file" "invalid_ics_file": "There was a problem reading the calendar information. See the error log for additional details."
} }
}, },
"selector": { "selector": {