From 5b8f1850fa4b65083f028a4d1cc5c6c359dc9f04 Mon Sep 17 00:00:00 2001 From: Marcelo Moreira de Mello Date: Mon, 3 Apr 2017 02:46:18 -0400 Subject: [PATCH] Makes amcrest.sensor to handle properly the scan_interval option. (#6885) * Makes amcrest.sensor to handle scan_interval option as expected. * Added _LOGGER.debug statement for troubleshooting. * Fixed lint --- homeassistant/components/sensor/amcrest.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/sensor/amcrest.py b/homeassistant/components/sensor/amcrest.py index 79e886c154d..5a349d28b7c 100644 --- a/homeassistant/components/sensor/amcrest.py +++ b/homeassistant/components/sensor/amcrest.py @@ -13,8 +13,7 @@ import homeassistant.helpers.config_validation as cv from homeassistant.components.sensor import PLATFORM_SCHEMA from homeassistant.const import ( CONF_HOST, CONF_NAME, CONF_MONITORED_CONDITIONS, - CONF_SCAN_INTERVAL, CONF_USERNAME, CONF_PASSWORD, - CONF_PORT, STATE_UNKNOWN) + CONF_USERNAME, CONF_PASSWORD, CONF_PORT, STATE_UNKNOWN) from homeassistant.helpers.entity import Entity import homeassistant.loader as loader @@ -29,7 +28,7 @@ NOTIFICATION_TITLE = 'Amcrest Sensor Setup' DEFAULT_NAME = 'Amcrest' DEFAULT_PORT = 80 -DEFAULT_SCAN_INTERVAL = timedelta(seconds=10) +SCAN_INTERVAL = timedelta(seconds=10) # Sensor types are defined like: Name, units, icon SENSOR_TYPES = { @@ -44,8 +43,6 @@ PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ vol.Required(CONF_PASSWORD): cv.string, vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string, vol.Optional(CONF_PORT, default=DEFAULT_PORT): cv.port, - vol.Optional(CONF_SCAN_INTERVAL, default=DEFAULT_SCAN_INTERVAL): - vol.All(vol.Coerce(int), vol.Range(min=1)), vol.Required(CONF_MONITORED_CONDITIONS, default=[]): vol.All(cv.ensure_list, [vol.In(SENSOR_TYPES)]), }) @@ -122,6 +119,8 @@ class AmcrestSensor(Entity): def update(self): """Get the latest data and updates the state.""" + _LOGGER.debug("Pulling data from %s sensor.", self._name) + try: version, build_date = self._camera.software_information self._attrs['Build Date'] = build_date.split('=')[-1]