jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 11:17:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce number of asyncio tasks created by bond (#84668)

Browse Source
This commit is contained in:
J. Nick Koston 2022-12-28 07:14:38 -10:00 committed by GitHub
parent cb37df6a61
commit 5bdaad9c13
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
homeassistant/components/bond/entity.py
View File

@ -3,9 +3,8 @@ from __future__ import annotations
from abc import abstractmethod from abc import abstractmethod
from asyncio import Lock, TimeoutError as AsyncIOTimeoutError from asyncio import Lock, TimeoutError as AsyncIOTimeoutError
from datetime import timedelta from datetime import datetime, timedelta
import logging import logging
from typing import Any
from aiohttp import ClientError from aiohttp import ClientError
from bond_async import BPUPSubscriptions from bond_async import BPUPSubscriptions
@ -50,7 +49,7 @@ class BondEntity(Entity):
self._sub_device = sub_device self._sub_device = sub_device
self._attr_available = True self._attr_available = True
self._bpup_subs = bpup_subs self._bpup_subs = bpup_subs
self._update_lock: Lock | None = None self._update_lock = Lock()
self._initialized = False self._initialized = False
if sub_device_id: if sub_device_id:
sub_device_id = f"_{sub_device_id}" sub_device_id = f"_{sub_device_id}"
@ -104,7 +103,8 @@ class BondEntity(Entity):
"""Fetch assumed state of the cover from the hub using API.""" """Fetch assumed state of the cover from the hub using API."""
await self._async_update_from_api() await self._async_update_from_api()
async def _async_update_if_bpup_not_alive(self, *_: Any) -> None: @callback
def _async_update_if_bpup_not_alive(self, now: datetime) -> None:
"""Fetch via the API if BPUP is not alive.""" """Fetch via the API if BPUP is not alive."""
if ( if (
self.hass.is_stopping self.hass.is_stopping
@ -113,8 +113,6 @@ class BondEntity(Entity):
and self.available and self.available
): ):
return return
assert self._update_lock is not None
if self._update_lock.locked(): if self._update_lock.locked():
_LOGGER.warning( _LOGGER.warning(
"Updating %s took longer than the scheduled update interval %s", "Updating %s took longer than the scheduled update interval %s",
@ -122,7 +120,10 @@ class BondEntity(Entity):
_FALLBACK_SCAN_INTERVAL, _FALLBACK_SCAN_INTERVAL,
) )
return return
self.hass.async_create_task(self._async_update())
async def _async_update(self) -> None:
"""Fetch via the API."""
async with self._update_lock: async with self._update_lock:
await self._async_update_from_api() await self._async_update_from_api()
self.async_write_ha_state() self.async_write_ha_state()
@ -170,7 +171,6 @@ class BondEntity(Entity):
async def async_added_to_hass(self) -> None: async def async_added_to_hass(self) -> None:
"""Subscribe to BPUP and start polling.""" """Subscribe to BPUP and start polling."""
await super().async_added_to_hass() await super().async_added_to_hass()
self._update_lock = Lock()
self._bpup_subs.subscribe(self._device_id, self._async_bpup_callback) self._bpup_subs.subscribe(self._device_id, self._async_bpup_callback)
self.async_on_remove( self.async_on_remove(
async_track_time_interval( async_track_time_interval(