From 5ca68cb273f26db8ee8d95c938e4161f8fb9264c Mon Sep 17 00:00:00 2001 From: Jan Bouwhuis Date: Thu, 16 Jan 2025 15:24:40 +0100 Subject: [PATCH] Improve incomfort coordinator logging (#135777) --- homeassistant/components/incomfort/coordinator.py | 4 ++-- tests/components/incomfort/test_init.py | 15 +++++++++++++-- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/incomfort/coordinator.py b/homeassistant/components/incomfort/coordinator.py index a5c8da0c208..20cc8e7cc69 100644 --- a/homeassistant/components/incomfort/coordinator.py +++ b/homeassistant/components/incomfort/coordinator.py @@ -66,10 +66,10 @@ class InComfortDataCoordinator(DataUpdateCoordinator[InComfortData]): for heater in self.incomfort_data.heaters: await heater.update() except TimeoutError as exc: - raise UpdateFailed from exc + raise UpdateFailed("Timeout error") from exc except IncomfortError as exc: if isinstance(exc.message, ClientResponseError): if exc.message.status == 401: raise ConfigEntryError("Incorrect credentials") from exc - raise UpdateFailed from exc + raise UpdateFailed(exc.message) from exc return self.incomfort_data diff --git a/tests/components/incomfort/test_init.py b/tests/components/incomfort/test_init.py index 0390a47a616..504ab02ea81 100644 --- a/tests/components/incomfort/test_init.py +++ b/tests/components/incomfort/test_init.py @@ -3,7 +3,7 @@ from datetime import timedelta from unittest.mock import MagicMock, patch -from aiohttp import ClientResponseError +from aiohttp import ClientResponseError, RequestInfo from freezegun.api import FrozenDateTimeFactory from incomfortclient import IncomfortError import pytest @@ -63,7 +63,18 @@ async def test_coordinator_updates( "exc", [ IncomfortError(ClientResponseError(None, None, status=401)), - IncomfortError(ClientResponseError(None, None, status=500)), + IncomfortError( + ClientResponseError( + RequestInfo( + url="http://example.com", + method="GET", + headers=[], + real_url="http://example.com", + ), + None, + status=500, + ) + ), IncomfortError(ValueError("some_error")), TimeoutError, ],