jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 15:17:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleaner unit tests for Swiss public transport (#123660)

Browse Source 
cleaner unit tests
This commit is contained in:
Cyrill Raccaud 2024-08-12 16:19:36 +02:00 committed by GitHub
parent 342ba1b599
commit 5cb9901134
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/components/swiss_public_transport/test_service.py
View File

@ -38,18 +38,18 @@ MOCK_DATA_STEP_BASE = {
@pytest.mark.parametrize( @pytest.mark.parametrize(
("limit", "config_data"), ("data", "config_data"),
[ [
(1, MOCK_DATA_STEP_BASE), ({ATTR_LIMIT: 1}, MOCK_DATA_STEP_BASE),
(2, MOCK_DATA_STEP_BASE), ({ATTR_LIMIT: 2}, MOCK_DATA_STEP_BASE),
(3, MOCK_DATA_STEP_BASE), ({ATTR_LIMIT: 3}, MOCK_DATA_STEP_BASE),
(CONNECTIONS_MAX, MOCK_DATA_STEP_BASE), ({ATTR_LIMIT: CONNECTIONS_MAX}, MOCK_DATA_STEP_BASE),
(None, MOCK_DATA_STEP_BASE), ({}, MOCK_DATA_STEP_BASE),
], ],
) )
async def test_service_call_fetch_connections_success( async def test_service_call_fetch_connections_success(
hass: HomeAssistant, hass: HomeAssistant,
limit: int, data: dict,
config_data, config_data,
) -> None: ) -> None:
"""Test the fetch_connections service.""" """Test the fetch_connections service."""
@ -59,7 +59,7 @@ async def test_service_call_fetch_connections_success(
config_entry = MockConfigEntry( config_entry = MockConfigEntry(
domain=DOMAIN, domain=DOMAIN,
data=config_data, data=config_data,
title=f"Service test call with limit={limit}", title=f"Service test call with data={data}",
unique_id=unique_id, unique_id=unique_id,
entry_id=f"entry_{unique_id}", entry_id=f"entry_{unique_id}",
) )
@ -69,14 +69,12 @@ async def test_service_call_fetch_connections_success(
return_value=AsyncMock(), return_value=AsyncMock(),
) as mock: ) as mock:
mock().connections = json.loads(load_fixture("connections.json", DOMAIN))[ mock().connections = json.loads(load_fixture("connections.json", DOMAIN))[
0 : (limit or CONNECTIONS_COUNT) + 2 0 : data.get(ATTR_LIMIT, CONNECTIONS_COUNT) + 2
] ]
await setup_integration(hass, config_entry) await setup_integration(hass, config_entry)
data = {ATTR_CONFIG_ENTRY_ID: config_entry.entry_id} data[ATTR_CONFIG_ENTRY_ID] = config_entry.entry_id
if limit is not None:
data[ATTR_LIMIT] = limit
assert hass.services.has_service(DOMAIN, SERVICE_FETCH_CONNECTIONS) assert hass.services.has_service(DOMAIN, SERVICE_FETCH_CONNECTIONS)
response = await hass.services.async_call( response = await hass.services.async_call(
domain=DOMAIN, domain=DOMAIN,
@ -87,7 +85,7 @@ async def test_service_call_fetch_connections_success(
) )
await hass.async_block_till_done() await hass.async_block_till_done()
assert response["connections"] is not None assert response["connections"] is not None
assert len(response["connections"]) == (limit or CONNECTIONS_COUNT) assert len(response["connections"]) == data.get(ATTR_LIMIT, CONNECTIONS_COUNT)
@pytest.mark.parametrize( @pytest.mark.parametrize(