jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Properly report cover positions to prometheus (#110157)

Browse Source
This commit is contained in:
Adam Goode 2024-02-12 09:33:03 -05:00 committed by GitHub
parent fb878836a8
commit 5cdc3cec32
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
homeassistant/components/prometheus/__init__.py
View File

@ -21,7 +21,10 @@ from homeassistant.components.climate import (
ATTR_TARGET_TEMP_LOW, ATTR_TARGET_TEMP_LOW,
HVACAction, HVACAction,
) )
from homeassistant.components.cover import ATTR_POSITION, ATTR_TILT_POSITION from homeassistant.components.cover import (
ATTR_CURRENT_POSITION,
ATTR_CURRENT_TILT_POSITION,
)
from homeassistant.components.http import HomeAssistantView from homeassistant.components.http import HomeAssistantView
from homeassistant.components.humidifier import ATTR_AVAILABLE_MODES, ATTR_HUMIDITY from homeassistant.components.humidifier import ATTR_AVAILABLE_MODES, ATTR_HUMIDITY
from homeassistant.components.light import ATTR_BRIGHTNESS from homeassistant.components.light import ATTR_BRIGHTNESS
@ -437,7 +440,7 @@ class PrometheusMetrics:
float(cover_state == state.state) float(cover_state == state.state)
) )
position = state.attributes.get(ATTR_POSITION) position = state.attributes.get(ATTR_CURRENT_POSITION)
if position is not None: if position is not None:
position_metric = self._metric( position_metric = self._metric(
"cover_position", "cover_position",
@ -446,7 +449,7 @@ class PrometheusMetrics:
) )
position_metric.labels(**self._labels(state)).set(float(position)) position_metric.labels(**self._labels(state)).set(float(position))
tilt_position = state.attributes.get(ATTR_TILT_POSITION) tilt_position = state.attributes.get(ATTR_CURRENT_TILT_POSITION)
if tilt_position is not None: if tilt_position is not None:
tilt_position_metric = self._metric( tilt_position_metric = self._metric(
"cover_tilt_position", "cover_tilt_position",

4
tests/components/prometheus/test_init.py
View File

@ -1352,7 +1352,7 @@ async def cover_fixture(
suggested_object_id="position_shade", suggested_object_id="position_shade",
original_name="Position Shade", original_name="Position Shade",
) )
cover_position_attributes = {cover.ATTR_POSITION: 50} cover_position_attributes = {cover.ATTR_CURRENT_POSITION: 50}
set_state_with_entry(hass, cover_position, STATE_OPEN, cover_position_attributes) set_state_with_entry(hass, cover_position, STATE_OPEN, cover_position_attributes)
data["cover_position"] = cover_position data["cover_position"] = cover_position
@ -1363,7 +1363,7 @@ async def cover_fixture(
suggested_object_id="tilt_position_shade", suggested_object_id="tilt_position_shade",
original_name="Tilt Position Shade", original_name="Tilt Position Shade",
) )
cover_tilt_position_attributes = {cover.ATTR_TILT_POSITION: 50} cover_tilt_position_attributes = {cover.ATTR_CURRENT_TILT_POSITION: 50}
set_state_with_entry( set_state_with_entry(
hass, cover_tilt_position, STATE_OPEN, cover_tilt_position_attributes hass, cover_tilt_position, STATE_OPEN, cover_tilt_position_attributes
) )