jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 03:07:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: 17track package summary status is not updated when there are no more packages in that summary (#64421)

Browse Source 
* 17track package status is not updated when there are no packages

* 17track package status is not updated when there are no packages

* 17track package status is not updated when there are no packages
This commit is contained in:
Regev Brody 2022-01-19 17:35:20 +02:00 committed by GitHub
parent 24e24a5157
commit 6176bb954c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/seventeentrack/sensor.py
View File

@ -150,8 +150,9 @@ class SeventeenTrackSummarySensor(SensorEntity):
} }
) )
if package_data: self._attr_extra_state_attributes[ATTR_PACKAGES] = (
self._attr_extra_state_attributes[ATTR_PACKAGES] = package_data package_data if package_data else None
)
self._state = self._data.summary.get(self._status) self._state = self._data.summary.get(self._status)

34
tests/components/seventeentrack/test_sensor.py
View File

@ -379,12 +379,37 @@ async def test_becomes_delivered_not_shown_notification(hass):
async def test_summary_correctly_updated(hass): async def test_summary_correctly_updated(hass):
"""Ensure summary entities are not duplicated.""" """Ensure summary entities are not duplicated."""
package = Package(
tracking_number="456",
destination_country=206,
friendly_name="friendly name 1",
info_text="info text 1",
location="location 1",
timestamp="2020-08-10 10:32",
origin_country=206,
package_type=2,
status=30,
)
ProfileMock.package_list = [package]
await _setup_seventeentrack(hass, summary_data=DEFAULT_SUMMARY) await _setup_seventeentrack(hass, summary_data=DEFAULT_SUMMARY)
assert len(hass.states.async_entity_ids()) == 7 assert len(hass.states.async_entity_ids()) == 8
for state in hass.states.async_all(): for state in hass.states.async_all():
if state.entity_id == "sensor.seventeentrack_package_456":
break
assert state.state == "0" assert state.state == "0"
assert (
len(
hass.states.get(
"sensor.seventeentrack_packages_ready_to_be_picked_up"
).attributes["packages"]
)
== 1
)
ProfileMock.package_list = []
ProfileMock.summary_data = NEW_SUMMARY_DATA ProfileMock.summary_data = NEW_SUMMARY_DATA
await _goto_future(hass) await _goto_future(hass)
@ -393,6 +418,13 @@ async def test_summary_correctly_updated(hass):
for state in hass.states.async_all(): for state in hass.states.async_all():
assert state.state == "1" assert state.state == "1"
assert (
hass.states.get(
"sensor.seventeentrack_packages_ready_to_be_picked_up"
).attributes["packages"]
is None
)
async def test_utc_timestamp(hass): async def test_utc_timestamp(hass):
"""Ensure package timestamp is converted correctly from HA-defined time zone to UTC.""" """Ensure package timestamp is converted correctly from HA-defined time zone to UTC."""