jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 19:27:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use shorthand attributes in iZone (#99397)

Browse Source
This commit is contained in:
Joost Lekkerkerker 2023-09-01 10:34:09 +02:00 committed by GitHub
parent 6c93865cee
commit 65246b99ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
homeassistant/components/izone/climate.py
View File

@ -135,6 +135,7 @@ class ControllerDevice(ClimateEntity):
_attr_temperature_unit = UnitOfTemperature.CELSIUS _attr_temperature_unit = UnitOfTemperature.CELSIUS
_attr_has_entity_name = True _attr_has_entity_name = True
_attr_name = None _attr_name = None
_attr_target_temperature_step = 0.5
def __init__(self, controller: Controller) -> None: def __init__(self, controller: Controller) -> None:
"""Initialise ControllerDevice.""" """Initialise ControllerDevice."""
@ -165,13 +166,13 @@ class ControllerDevice(ClimateEntity):
self._fan_to_pizone = {} self._fan_to_pizone = {}
for fan in controller.fan_modes: for fan in controller.fan_modes:
self._fan_to_pizone[_IZONE_FAN_TO_HA[fan]] = fan self._fan_to_pizone[_IZONE_FAN_TO_HA[fan]] = fan
self._available = True
self._attr_unique_id = controller.device_uid
self._attr_device_info = DeviceInfo( self._attr_device_info = DeviceInfo(
identifiers={(IZONE, self.unique_id)}, identifiers={(IZONE, controller.device_uid)},
manufacturer="IZone", manufacturer="IZone",
model=self._controller.sys_type, model=controller.sys_type,
name=f"iZone Controller {self._controller.device_uid}", name=f"iZone Controller {controller.device_uid}",
) )
# Create the zones # Create the zones
@ -224,11 +225,6 @@ class ControllerDevice(ClimateEntity):
) )
) )
@property
def available(self) -> bool:
"""Return True if entity is available."""
return self._available
@callback @callback
def set_available(self, available: bool, ex: Exception | None = None) -> None: def set_available(self, available: bool, ex: Exception | None = None) -> None:
"""Set availability for the controller. """Set availability for the controller.
@ -247,17 +243,12 @@ class ControllerDevice(ClimateEntity):
ex, ex,
) )
self._available = available self._attr_available = available
self.async_write_ha_state() self.async_write_ha_state()
for zone in self.zones.values(): for zone in self.zones.values():
if zone.hass is not None: if zone.hass is not None:
zone.async_schedule_update_ha_state() zone.async_schedule_update_ha_state()
@property
def unique_id(self) -> str:
"""Return the ID of the controller device."""
return self._controller.device_uid
@property @property
def extra_state_attributes(self) -> Mapping[str, Any]: def extra_state_attributes(self) -> Mapping[str, Any]:
"""Return the optional state attributes.""" """Return the optional state attributes."""
@ -364,11 +355,6 @@ class ControllerDevice(ClimateEntity):
"""Return the current supply, or in duct, temperature.""" """Return the current supply, or in duct, temperature."""
return self._controller.temp_supply return self._controller.temp_supply
@property
def target_temperature_step(self) -> float | None:
"""Return the supported step of target temperature."""
return 0.5
@property @property
def fan_mode(self) -> str | None: def fan_mode(self) -> str | None:
"""Return the fan setting.""" """Return the fan setting."""
@ -444,6 +430,7 @@ class ZoneDevice(ClimateEntity):
_attr_has_entity_name = True _attr_has_entity_name = True
_attr_name = None _attr_name = None
_attr_temperature_unit = UnitOfTemperature.CELSIUS _attr_temperature_unit = UnitOfTemperature.CELSIUS
_attr_target_temperature_step = 0.5
def __init__(self, controller: ControllerDevice, zone: Zone) -> None: def __init__(self, controller: ControllerDevice, zone: Zone) -> None:
"""Initialise ZoneDevice.""" """Initialise ZoneDevice."""
@ -462,7 +449,8 @@ class ZoneDevice(ClimateEntity):
HVACMode.HEAT_COOL: Zone.Mode.AUTO, HVACMode.HEAT_COOL: Zone.Mode.AUTO,
} }
self._attr_supported_features |= ClimateEntityFeature.TARGET_TEMPERATURE self._attr_supported_features |= ClimateEntityFeature.TARGET_TEMPERATURE
self._attr_unique_id = f"{controller.unique_id}_z{zone.index + 1}"
assert controller.unique_id
self._attr_device_info = DeviceInfo( self._attr_device_info = DeviceInfo(
identifiers={ identifiers={
(IZONE, controller.unique_id, zone.index) # type:ignore[arg-type] (IZONE, controller.unique_id, zone.index) # type:ignore[arg-type]
@ -509,11 +497,6 @@ class ZoneDevice(ClimateEntity):
"""Return True if entity is available.""" """Return True if entity is available."""
return self._controller.available return self._controller.available
@property
def unique_id(self) -> str:
"""Return the ID of the controller device."""
return f"{self._controller.unique_id}_z{self._zone.index + 1}"
@property @property
@_return_on_connection_error(0) @_return_on_connection_error(0)
def supported_features(self) -> ClimateEntityFeature: def supported_features(self) -> ClimateEntityFeature:
@ -548,11 +531,6 @@ class ZoneDevice(ClimateEntity):
return None return None
return self._zone.temp_setpoint return self._zone.temp_setpoint
@property
def target_temperature_step(self) -> float:
"""Return the supported step of target temperature."""
return 0.5
@property @property
def min_temp(self) -> float: def min_temp(self) -> float:
"""Return the minimum temperature.""" """Return the minimum temperature."""