From 6733f86c6182d42f1478709aeb07fd15be20ebc6 Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Mon, 10 Jun 2024 14:57:34 +0200 Subject: [PATCH] Use service_calls fixture in helper tests (#119275) Co-authored-by: Franck Nijhof --- tests/helpers/test_condition.py | 185 +++++++++++++++++--------------- tests/helpers/test_trigger.py | 52 ++++----- 2 files changed, 127 insertions(+), 110 deletions(-) diff --git a/tests/helpers/test_condition.py b/tests/helpers/test_condition.py index ce114058453..31f813469cc 100644 --- a/tests/helpers/test_condition.py +++ b/tests/helpers/test_condition.py @@ -30,16 +30,9 @@ from homeassistant.helpers.template import Template from homeassistant.setup import async_setup_component import homeassistant.util.dt as dt_util -from tests.common import async_mock_service from tests.typing import WebSocketGenerator -@pytest.fixture -def calls(hass: HomeAssistant) -> list[ServiceCall]: - """Track calls to a mock service.""" - return async_mock_service(hass, "test", "automation") - - def assert_element(trace_element, expected_element, path): """Assert a trace element is as expected. @@ -2215,7 +2208,9 @@ async def assert_automation_condition_trace(hass_ws_client, automation_id, expec async def test_if_action_before_sunrise_no_offset( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was before sunrise. @@ -2241,7 +2236,7 @@ async def test_if_action_before_sunrise_no_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2253,7 +2248,7 @@ async def test_if_action_before_sunrise_no_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2265,7 +2260,7 @@ async def test_if_action_before_sunrise_no_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2277,7 +2272,7 @@ async def test_if_action_before_sunrise_no_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2286,7 +2281,9 @@ async def test_if_action_before_sunrise_no_offset( async def test_if_action_after_sunrise_no_offset( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was after sunrise. @@ -2312,7 +2309,7 @@ async def test_if_action_after_sunrise_no_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2324,7 +2321,7 @@ async def test_if_action_after_sunrise_no_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2336,7 +2333,7 @@ async def test_if_action_after_sunrise_no_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2348,7 +2345,7 @@ async def test_if_action_after_sunrise_no_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2357,7 +2354,9 @@ async def test_if_action_after_sunrise_no_offset( async def test_if_action_before_sunrise_with_offset( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was before sunrise with offset. @@ -2387,7 +2386,7 @@ async def test_if_action_before_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2399,7 +2398,7 @@ async def test_if_action_before_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2411,7 +2410,7 @@ async def test_if_action_before_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2423,7 +2422,7 @@ async def test_if_action_before_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2435,7 +2434,7 @@ async def test_if_action_before_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2447,7 +2446,7 @@ async def test_if_action_before_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2459,7 +2458,7 @@ async def test_if_action_before_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2471,7 +2470,7 @@ async def test_if_action_before_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2480,7 +2479,9 @@ async def test_if_action_before_sunrise_with_offset( async def test_if_action_before_sunset_with_offset( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was before sunset with offset. @@ -2510,7 +2511,7 @@ async def test_if_action_before_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2522,7 +2523,7 @@ async def test_if_action_before_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2534,7 +2535,7 @@ async def test_if_action_before_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2546,7 +2547,7 @@ async def test_if_action_before_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 3 + assert len(service_calls) == 3 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2558,7 +2559,7 @@ async def test_if_action_before_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 4 + assert len(service_calls) == 4 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2570,7 +2571,7 @@ async def test_if_action_before_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 5 + assert len(service_calls) == 5 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2582,7 +2583,7 @@ async def test_if_action_before_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 6 + assert len(service_calls) == 6 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2594,7 +2595,7 @@ async def test_if_action_before_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 6 + assert len(service_calls) == 6 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2603,7 +2604,9 @@ async def test_if_action_before_sunset_with_offset( async def test_if_action_after_sunrise_with_offset( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was after sunrise with offset. @@ -2633,7 +2636,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2645,7 +2648,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2657,7 +2660,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2669,7 +2672,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2681,7 +2684,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2693,7 +2696,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 3 + assert len(service_calls) == 3 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2705,7 +2708,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 4 + assert len(service_calls) == 4 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2717,7 +2720,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 5 + assert len(service_calls) == 5 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2729,7 +2732,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 6 + assert len(service_calls) == 6 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2741,7 +2744,7 @@ async def test_if_action_after_sunrise_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 6 + assert len(service_calls) == 6 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2750,7 +2753,9 @@ async def test_if_action_after_sunrise_with_offset( async def test_if_action_after_sunset_with_offset( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was after sunset with offset. @@ -2780,7 +2785,7 @@ async def test_if_action_after_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2792,7 +2797,7 @@ async def test_if_action_after_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2804,7 +2809,7 @@ async def test_if_action_after_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2816,7 +2821,7 @@ async def test_if_action_after_sunset_with_offset( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2825,7 +2830,9 @@ async def test_if_action_after_sunset_with_offset( async def test_if_action_after_and_before_during( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was after sunrise and before sunset. @@ -2855,7 +2862,7 @@ async def test_if_action_after_and_before_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2871,7 +2878,7 @@ async def test_if_action_after_and_before_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2883,7 +2890,7 @@ async def test_if_action_after_and_before_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2899,7 +2906,7 @@ async def test_if_action_after_and_before_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2915,7 +2922,7 @@ async def test_if_action_after_and_before_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 3 + assert len(service_calls) == 3 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2928,7 +2935,9 @@ async def test_if_action_after_and_before_during( async def test_if_action_before_or_after_during( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was before sunrise or after sunset. @@ -2958,7 +2967,7 @@ async def test_if_action_before_or_after_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2974,7 +2983,7 @@ async def test_if_action_before_or_after_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -2990,7 +2999,7 @@ async def test_if_action_before_or_after_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3006,7 +3015,7 @@ async def test_if_action_before_or_after_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3022,7 +3031,7 @@ async def test_if_action_before_or_after_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 3 + assert len(service_calls) == 3 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3038,7 +3047,7 @@ async def test_if_action_before_or_after_during( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 4 + assert len(service_calls) == 4 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3051,7 +3060,9 @@ async def test_if_action_before_or_after_during( async def test_if_action_before_sunrise_no_offset_kotzebue( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was before sunrise. @@ -3083,7 +3094,7 @@ async def test_if_action_before_sunrise_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3095,7 +3106,7 @@ async def test_if_action_before_sunrise_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3107,7 +3118,7 @@ async def test_if_action_before_sunrise_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3119,7 +3130,7 @@ async def test_if_action_before_sunrise_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3128,7 +3139,9 @@ async def test_if_action_before_sunrise_no_offset_kotzebue( async def test_if_action_after_sunrise_no_offset_kotzebue( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was after sunrise. @@ -3160,7 +3173,7 @@ async def test_if_action_after_sunrise_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3172,7 +3185,7 @@ async def test_if_action_after_sunrise_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3184,7 +3197,7 @@ async def test_if_action_after_sunrise_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3196,7 +3209,7 @@ async def test_if_action_after_sunrise_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3205,7 +3218,9 @@ async def test_if_action_after_sunrise_no_offset_kotzebue( async def test_if_action_before_sunset_no_offset_kotzebue( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was before sunrise. @@ -3237,7 +3252,7 @@ async def test_if_action_before_sunset_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 0 + assert len(service_calls) == 0 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3249,7 +3264,7 @@ async def test_if_action_before_sunset_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3261,7 +3276,7 @@ async def test_if_action_before_sunset_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3273,7 +3288,7 @@ async def test_if_action_before_sunset_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3282,7 +3297,9 @@ async def test_if_action_before_sunset_no_offset_kotzebue( async def test_if_action_after_sunset_no_offset_kotzebue( - hass: HomeAssistant, hass_ws_client: WebSocketGenerator, calls: list[ServiceCall] + hass: HomeAssistant, + hass_ws_client: WebSocketGenerator, + service_calls: list[ServiceCall], ) -> None: """Test if action was after sunrise. @@ -3314,7 +3331,7 @@ async def test_if_action_after_sunset_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3326,7 +3343,7 @@ async def test_if_action_after_sunset_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3338,7 +3355,7 @@ async def test_if_action_after_sunset_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 await assert_automation_condition_trace( hass_ws_client, "sun", @@ -3350,7 +3367,7 @@ async def test_if_action_after_sunset_no_offset_kotzebue( with freeze_time(now): hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 await assert_automation_condition_trace( hass_ws_client, "sun", diff --git a/tests/helpers/test_trigger.py b/tests/helpers/test_trigger.py index 0ab02b8c4dc..e8322c7e660 100644 --- a/tests/helpers/test_trigger.py +++ b/tests/helpers/test_trigger.py @@ -15,14 +15,6 @@ from homeassistant.helpers.trigger import ( ) from homeassistant.setup import async_setup_component -from tests.common import async_mock_service - - -@pytest.fixture -def calls(hass): - """Track calls to a mock service.""" - return async_mock_service(hass, "test", "automation") - async def test_bad_trigger_platform(hass: HomeAssistant) -> None: """Test bad trigger platform.""" @@ -45,7 +37,9 @@ async def test_trigger_variables(hass: HomeAssistant) -> None: """Test trigger variables.""" -async def test_if_fires_on_event(hass: HomeAssistant, calls) -> None: +async def test_if_fires_on_event( + hass: HomeAssistant, service_calls: list[ServiceCall] +) -> None: """Test the firing of events.""" assert await async_setup_component( hass, @@ -70,12 +64,12 @@ async def test_if_fires_on_event(hass: HomeAssistant, calls) -> None: hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert len(calls) == 1 - assert calls[0].data["hello"] == "Paulus + test_event" + assert len(service_calls) == 1 + assert service_calls[0].data["hello"] == "Paulus + test_event" async def test_if_disabled_trigger_not_firing( - hass: HomeAssistant, calls: list[ServiceCall] + hass: HomeAssistant, service_calls: list[ServiceCall] ) -> None: """Test disabled triggers don't fire.""" assert await async_setup_component( @@ -103,15 +97,15 @@ async def test_if_disabled_trigger_not_firing( hass.bus.async_fire("disabled_trigger_event") await hass.async_block_till_done() - assert not calls + assert not service_calls hass.bus.async_fire("enabled_trigger_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 async def test_trigger_enabled_templates( - hass: HomeAssistant, calls: list[ServiceCall] + hass: HomeAssistant, service_calls: list[ServiceCall] ) -> None: """Test triggers enabled by template.""" assert await async_setup_component( @@ -150,23 +144,25 @@ async def test_trigger_enabled_templates( hass.bus.async_fire("falsy_template_trigger_event") await hass.async_block_till_done() - assert not calls + assert not service_calls hass.bus.async_fire("falsy_trigger_event") await hass.async_block_till_done() - assert not calls + assert not service_calls hass.bus.async_fire("truthy_template_trigger_event") await hass.async_block_till_done() - assert len(calls) == 1 + assert len(service_calls) == 1 hass.bus.async_fire("truthy_trigger_event") await hass.async_block_till_done() - assert len(calls) == 2 + assert len(service_calls) == 2 async def test_trigger_enabled_template_limited( - hass: HomeAssistant, calls: list[ServiceCall], caplog: pytest.LogCaptureFixture + hass: HomeAssistant, + service_calls: list[ServiceCall], + caplog: pytest.LogCaptureFixture, ) -> None: """Test triggers enabled invalid template.""" assert await async_setup_component( @@ -190,12 +186,14 @@ async def test_trigger_enabled_template_limited( hass.bus.async_fire("test_event") await hass.async_block_till_done() - assert not calls + assert not service_calls assert "Error rendering enabled template" in caplog.text async def test_trigger_alias( - hass: HomeAssistant, calls: list[ServiceCall], caplog: pytest.LogCaptureFixture + hass: HomeAssistant, + service_calls: list[ServiceCall], + caplog: pytest.LogCaptureFixture, ) -> None: """Test triggers support aliases.""" assert await async_setup_component( @@ -220,8 +218,8 @@ async def test_trigger_alias( hass.bus.async_fire("trigger_event") await hass.async_block_till_done() - assert len(calls) == 1 - assert calls[0].data["alias"] == "My event" + assert len(service_calls) == 1 + assert service_calls[0].data["alias"] == "My event" assert ( "Automation trigger 'My event' triggered by event 'trigger_event'" in caplog.text @@ -229,7 +227,9 @@ async def test_trigger_alias( async def test_async_initialize_triggers( - hass: HomeAssistant, calls: list[ServiceCall], caplog: pytest.LogCaptureFixture + hass: HomeAssistant, + service_calls: list[ServiceCall], + caplog: pytest.LogCaptureFixture, ) -> None: """Test async_initialize_triggers with different action types.""" @@ -287,7 +287,7 @@ async def test_async_initialize_triggers( unsub() -async def test_pluggable_action(hass: HomeAssistant, calls: list[ServiceCall]): +async def test_pluggable_action(hass: HomeAssistant, service_calls: list[ServiceCall]): """Test normal behavior of pluggable actions.""" update_1 = MagicMock() update_2 = MagicMock()