jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-11-12 20:40:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add ecobee set_sensors_used_in_climate service (#102871)

Browse Source 
* Add set_active_sensors Service

* Remove version bump from service addition commit

* Reviewer suggested changes

* Changed naming to be more clear of functionality

* Adjusted additional naming to follow new convention

* Updated to pass failing CI tests

* Fix typo

* Fix to pass CI

* Changed argument from climate_name to preset_mode and changed service error

* Made loop more clear and changed raised error to log msg

* Fix typo

Co-authored-by: Erik Montnemery <erik@montnemery.com>

* Removed code that was accidentally added back in and fixed mypy errors

* Add icon for service

* Added sensors as attributes and updated tests

* Revert changes made in #126587

* Added tests for remote_sensors and set_sensors_used_in_climate

* Changed back to load multiplatforms (#126587)

* Check for empty sensor list and negative tests for errors raised

* Added tests and fixed errors

* Add hass to class init to allow for device_registry lookup at startup and check for name changed by user

* Added tests to test the new functions

* Simplified code and fixed testing error for simplification

* Added freeze in test

* Fixed device filtering

* Simplified code section

* Maintains the ability to call `set_sensors_used_in_climate` function even is the user changes the device name from the ecobee app or thermostat without needing to reload home assistant.

* Update tests with new functionality. Changed thermostat identifier to a string, since that is what is provided via the ecobee api

* Changed function parameter

* Search for specific ecobee identifier

* Moved errors to strings.json

* Added test for sensor not on thermostat

* Improved tests and updated device check

* Added attributes to _unrecoreded_attributes

* Changed name to be more clear

* Improve error message and add test for added property

* Renamed variables for clarity

* Added device_id to available_sensors to make it easier on user to find it

---------

Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Erik Montnemery <erik@montnemery.com>
This commit is contained in:
myztillx
2024-10-21 10:21:56 -04:00
committed by GitHub
parent 25f66e6ac0
commit 6861bbed79
8 changed files with 560 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/components/ecobee/common.py
View File

@@ -11,7 +11,7 @@ from tests.common import MockConfigEntry
async def setup_platform(
hass: HomeAssistant,
platform: str,
platforms: str | list[str],
) -> MockConfigEntry:
"""Set up the ecobee platform."""
mock_entry = MockConfigEntry(
@@ -24,7 +24,9 @@ async def setup_platform(
)
mock_entry.add_to_hass(hass)
with patch("homeassistant.components.ecobee.PLATFORMS", [platform]):
platforms = [platforms] if isinstance(platforms, str) else platforms
with patch("homeassistant.components.ecobee.PLATFORMS", platforms):
await hass.config_entries.async_setup(mock_entry.entry_id)
await hass.async_block_till_done()
return mock_entry