From 6901c24ab7b1d5913f3b4a92f17afa3aaa189a8c Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Thu, 13 Jun 2024 17:03:16 +0200 Subject: [PATCH] Fix dangerous-default-value warnings in aussie broadband tests (#119596) --- tests/components/aussie_broadband/common.py | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/components/aussie_broadband/common.py b/tests/components/aussie_broadband/common.py index 1c992d116d1..a2bc79a42a6 100644 --- a/tests/components/aussie_broadband/common.py +++ b/tests/components/aussie_broadband/common.py @@ -1,12 +1,15 @@ """Aussie Broadband common helpers for tests.""" +from typing import Any from unittest.mock import patch from homeassistant.components.aussie_broadband.const import ( CONF_SERVICES, DOMAIN as AUSSIE_BROADBAND_DOMAIN, ) -from homeassistant.const import CONF_PASSWORD, CONF_USERNAME +from homeassistant.const import CONF_PASSWORD, CONF_USERNAME, Platform +from homeassistant.core import HomeAssistant +from homeassistant.helpers.typing import UNDEFINED, UndefinedType from tests.common import MockConfigEntry @@ -38,7 +41,11 @@ FAKE_DATA = { async def setup_platform( - hass, platforms=[], side_effect=None, usage={}, usage_effect=None + hass: HomeAssistant, + platforms: list[Platform] | UndefinedType = UNDEFINED, + side_effect=None, + usage: dict[str, Any] | UndefinedType = UNDEFINED, + usage_effect=None, ): """Set up the Aussie Broadband platform.""" mock_entry = MockConfigEntry( @@ -51,7 +58,10 @@ async def setup_platform( mock_entry.add_to_hass(hass) with ( - patch("homeassistant.components.aussie_broadband.PLATFORMS", platforms), + patch( + "homeassistant.components.aussie_broadband.PLATFORMS", + [] if platforms is UNDEFINED else platforms, + ), patch("aussiebb.asyncio.AussieBB.__init__", return_value=None), patch( "aussiebb.asyncio.AussieBB.login", @@ -65,7 +75,7 @@ async def setup_platform( ), patch( "aussiebb.asyncio.AussieBB.get_usage", - return_value=usage, + return_value={} if usage is UNDEFINED else usage, side_effect=usage_effect, ), ):